Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only push relevant attributes for reconciliation to reconcile service #12

Open
sroertgen opened this issue May 23, 2023 · 1 comment
Open
Assignees

Comments

@sroertgen
Copy link
Contributor

Right now every property of a node is pushed to the reconcile service.

This is not necessary, increases index size and might lead to unwanted behavior if the same prop with a different data type is pushed.

only the relevant props defined in the reconcile scheme (https://github.com/skohub-io/skohub-reconcile/blob/main/src/elastic/schema/esSchema.json) should be pushed

@sroertgen sroertgen self-assigned this May 23, 2023
@awagner-mainz
Copy link

Are the properties not potentially valuable for the preview or the data extension service? I didn't yet fully understand the latter in particular, but would that not provide "reconciliation spec coverage" for any property?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants