Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Story about why changes are made is unclear, where is the bug? #54

Open
gitgithan opened this issue Sep 7, 2023 · 0 comments
Labels
enhancement New feature or request needs content Requires content-specific changes only.

Comments

@gitgithan
Copy link

gitgithan commented Sep 7, 2023

On step 1 readme, we have Introduce a bug to be fixed later
It seems updating game text color to green is the bug as shown in

## Description:
- Updated game text color to green

Later in step 6 readme I made a mistake and introduced a bug. Instead of changing the text colors to green, we changed the whole game background..
This is confusing. Is updating game text color to green desired or not? It's a bug in step 1, then became the desired outcome in step 6?

Assuming there is indeed a bug introduced in step 1, where is the fix? It seems the fix is already done in .github/changes for the learner. If the learner is not supposed to do the bug fixing, why is the learner even introducing bugs by manipulating files in earlier steps when .github/changes already contains game-with-bug.js and game-fixed.js?

General feedback to improve all skill courses

  1. Screenshot an end state of Network Graph so learners can monitor whether they are working on correct branches
    image
  2. Add a list of common mistakes to help learners self help issues like steps not triggering
  • Working on wrong branch
  • Changed wrong file
  1. A meta course on how to go through Github Skills in video format would help learners get the most of of it.
  • How to monitor actions tab, what the UI means? (eg. branches shown, multiple workflow files can run for 1 commit, release triggers are not associated with any branch)
  • How to observe network graph
  • Explaining how the Update Step action adds commits to every branch

If I never developed the above introspection skills, I would've just clicked through the skills and gotten way less understanding out of them.

@nguyenalex836 nguyenalex836 added the enhancement New feature or request label May 31, 2024
@hectorsector hectorsector added the needs content Requires content-specific changes only. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs content Requires content-specific changes only.
Projects
None yet
Development

No branches or pull requests

4 participants
@hectorsector @gitgithan @nguyenalex836 and others