Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Appsettings override when application update #7

Open
picolino opened this issue Mar 7, 2023 · 2 comments
Open

[BUG] Appsettings override when application update #7

picolino opened this issue Mar 7, 2023 · 2 comments
Labels
up for grabs Good for newcomers

Comments

@picolino
Copy link
Member

picolino commented Mar 7, 2023

🐛 Bug Report

When application update, current appsettings.yaml file from current install directory overrides by new file from the installer.
This behaviour leads to overwrite all settings that was set previously.

Expected behavior

When application update, we should add missing configuration keys, but not overwrite already placed config keys.
Or make other migration behaviour that will be able to migrate config files more flexible while update.

Reproduction steps

  1. Install previous release
  2. Change appsettings.yaml file
  3. Update application to latest release using installer
  4. appsettings.yaml file became overwritten

Version: 1.0.2

@picolino picolino added the up for grabs Good for newcomers label Mar 7, 2023
@picolino
Copy link
Member Author

picolino commented Mar 11, 2023

Also, on macOS system - appsettings.yaml is a part of SSC.app bundle.
Apple recommends to not modify bundle files in runtime, so we should think about not store application settings into bundle itself on macOS

@picolino
Copy link
Member Author

Current version of SSC is not overriding appsettings.yaml file when install on Windows and Linux.
But for macOS it is still should be placed directly into Bundle. It is not much pain due to not so often usage on macOS systems as server-side, but it definitely will be problem in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grabs Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant