Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceMessages] Double notification when using notification actions #30

Open
Novack opened this issue Nov 23, 2023 · 3 comments
Open

Comments

@Novack
Copy link
Contributor

Novack commented Nov 23, 2023

Whenever using "Trash" or "Archive" actions from the desktop Windows notifications, then a second notification message arrives from the cloud. My presumption is that -same as with the unread notification messages-, each folder is triggering its own messages.

As a result, we receive the mail in the Inbox triggering a message, then we send that email to Trash or Archive in an unread state and that will trigger a second message from either of the receiving folder.

This is giving a really bad user experience, having the same notification twice for each email.

Propossed solution: newMessageNotifications message should be triggered only once for each mail.

Novack added a commit to Novack/skiff-windows-app that referenced this issue Dec 8, 2023
Issue skiff-org#30 temporarilily solved by this hack.
@Novack
Copy link
Contributor Author

Novack commented Dec 8, 2023

@amilich the true fix for this issue (same as #31) would be to fix the behaviour of the messages coming from the cloud app to the desktop app. That being said, until that moment comes, we can add a temporary workaround in the desktop app.

Have a look at the link, has a small hack that will prevent notifications to be triggered more than once for the same threadId:
78985e1

If you think is suitable, I can make a PR.

@amilich
Copy link
Contributor

amilich commented Dec 8, 2023

I agree with that, not sure what to do about folders yet. I was thinking to first focus on sending the notification info from the other Skiff apps (Pages/Drive/Calendar).

@Novack
Copy link
Contributor Author

Novack commented Dec 8, 2023

Oh right then, if you ok, I will send a PR, it will give us more time to consider the best approach for the underlying issue. 👍

amilich added a commit that referenced this issue Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants