Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22682] TripKitUI submodule and all modules inside refactoring #153

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[22682] TripKitUI submodule and all modules inside refactoring #153

wants to merge 6 commits into from

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripKit] convert GCAppResultInterface.java to kotlin
  • [TripKit] convert GCBoundingBox.java to kotlin
  • [TripKit] convert GCBoundingBoxInterface.java to kotlin
  • [TripKit] convert GCFoursquareResultInterface.java to kotlin
  • [TripKit] convert GCGoogleResultInterface.java to kotlin
  • [TripKit] convert GCQueryInterface.java to kotlin
  • [TripKit] convert GCResult.java to kotlin
  • [TripKit] convert GCResultInterface.java to kotlin
  • [TripKit] convert GCSkedGoResultInterface.java to kotlin
  • [TripKit] convert GeocodeUtilities.java to kotlin
  • [TripKit] convert GroupScoringResult.java to kotlin
  • [TripKit] convert MGAResultInterface.java to kotlin
  • [TripKit] convert MultiSourceGeocodingAggregator.java to kotlin
  • [TripKit] convert ScoringResult.java to kotlin
  • [TripKitUI] convert AppResultLocationAdapter.java to kotlin
  • [TripKitUI] convert FoursquareResultLocationAdapter.java to kotlin
  • [TripKitUI] convert GoogleResultLocationAdapter.java to kotlin
  • [TripKitUI] convert SkedgoResultLocationAdapter.java to kotlin
  • [TripKit] convert A2bRoutingApi.java to kotlin
  • [TripKit] convert FailoverA2bRoutingApi.java to kotlin
  • [TripKit] convert GCAppResult.java to kotlin
  • [TripKit] convert GCFoursquareResult.java to kotlin
  • [TripKit] convert GCGoogleResult.java to kotlin
  • [TripKit] convert GCQuery.java to kotlin
  • [TripKit] convert GCSkedgoResult.java to kotlin
  • [TripKit] convert LatLng.java to kotlin
  • [TripGov5] ODIN specific fixes for the updated TripGoActionButtonHandler class on other WL
  • [TripKit] convert AlertBlock.java to kotlin
  • [TripKit] convert ModeInfo.java to kotlin
  • [TripKit] convert RealtimeAlertApi.java to kotlin
  • [TripKit] convert RealtimeAlertResponse.java to kotlin
  • [TripKit] convert RealtimeAlertService.java to kotlin
  • [TripKit] convert Route.java to kotlin
  • [TripKit] convert BookingProvider.java to kotlin
  • [TripKit] convert BookingResolver.java to kotlin
  • [TripKit] convert BookingResolverImpl.java to kotlin
  • [TripKit] convert FlitWaysBookingResolver.java to kotlin
  • [TripKit] convert GoCatchBookingResolver.java to kotlin
  • [TripKit] convert IngogoBookingResolver.java to kotlin
  • [TripKit] convert LyftBookingResolver.java to kotlin
  • [TripKit] convert SmsBookingResolver.java to kotlin
  • [TripKit] convert TelBookingResolver.java to kotlin
  • [TripKit] convert WebBookingResolver.java to kotlin
  • [TripKit] convert ExtensionScope.java to kotlin
  • [TripKit] convert ExtraQueryMapProvider.java to kotlin
  • [TripKit] convert RegionInfoApi.java to kotlin
  • [TripKit] convert RegionInfoBody.java to kotlin
  • [TripKit] convert RegionInfoResponse.java to kotlin
  • [TripKit] convert RegionInfoService.java to kotlin
  • [TripKit] convert TspModule.java to kotlin
  • [TripKit] convert BaseUrlOverridingInterceptor.java to kotlin
  • [TripKit] convert BookingAction.java to kotlin
  • [TripKit] convert Cache.java to kotlin
  • [TripKit] convert CarPark.java to kotlin
  • [TripKit] convert Co2Preferences.java to kotlin
  • [TripKit] convert CursorToRegionConverter.java to kotlin
  • [TripKit] convert CursorToTransportModeConverter.java to kotlin
  • [TripKit] convert DataLoader.java to kotlin
  • [TripKit] convert DefaultCo2Preferences.java to kotlin
  • [TripKit] convert ExternalActionParams.java to kotlin
  • [TripKit] convert LineSegment.java to kotlin
  • [TripKit] convert LocationInfo.java to kotlin
  • [TripKit] convert LocationInfoApi.java to kotlin
  • [TripKit] convert LocationInfoDetails.java to kotlin
  • [TripKit] convert LocationInfoService.java to kotlin
  • [TripKit] convert LocationInfoServiceImpl.java to kotlin
  • [TripKit] convert MainModule.java to kotlin
  • [TripKit] convert RegionDatabaseHelper.java to kotlin
  • [TripKit] convert RegionFinder.java to kotlin
  • [TripKit] convert RegionsApi.java to kotlin
  • [TripKit] convert ServiceApi.java to kotlin

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

@MichaelReyes
Rename .java to .kt
9481143
@MichaelReyes
[22682]
16349ba 
- [TripKit] convert GCAppResultInterface.java to kotlin
- [TripKit] convert GCBoundingBox.java to kotlin
- [TripKit] convert GCBoundingBoxInterface.java to kotlin
- [TripKit] convert GCFoursquareResultInterface.java to kotlin
- [TripKit] convert GCGoogleResultInterface.java to kotlin
- [TripKit] convert GCQueryInterface.java to kotlin
- [TripKit] convert GCResult.java to kotlin
- [TripKit] convert GCResultInterface.java to kotlin
- [TripKit] convert GCSkedGoResultInterface.java to kotlin
- [TripKit] convert GeocodeUtilities.java to kotlin
- [TripKit] convert GroupScoringResult.java to kotlin
- [TripKit] convert MGAResultInterface.java to kotlin
- [TripKit] convert MultiSourceGeocodingAggregator.java to kotlin
- [TripKit] convert ScoringResult.java to kotlin
- [TripKitUI] convert AppResultLocationAdapter.java to kotlin
- [TripKitUI] convert FoursquareResultLocationAdapter.java to kotlin
- [TripKitUI] convert GoogleResultLocationAdapter.java to kotlin
- [TripKitUI] convert SkedgoResultLocationAdapter.java to kotlin
@MichaelReyes
[22682]
183636b 
- [TripKit] convert A2bRoutingApi.java to kotlin
- [TripKit] convert FailoverA2bRoutingApi.java to kotlin
- [TripKit] convert GCAppResult.java to kotlin
- [TripKit] convert GCFoursquareResult.java to kotlin
- [TripKit] convert GCGoogleResult.java to kotlin
- [TripKit] convert GCQuery.java to kotlin
- [TripKit] convert GCSkedgoResult.java to kotlin
- [TripKit] convert LatLng.java to kotlin
- [TripGov5] ODIN specific fixes for the updated TripGoActionButtonHandler class on other WL
@MichaelReyes
[22682]
b33ca3d 
- [TripKit] convert ModeCombinationStrategy.java to kotlin
- [TripKit] convert OnSubscribeLoadRegions.java to kotlin
- [TripKit] convert OnSubscribeLoadTransportModes.java to kotlin
- [TripKit] convert OnSubscribeSaveRegionsResponse.java to kotlin
- [TripKit] convert OutOfRegionsException.java to kotlin
- [TripKit] convert PeriodicRealTimeTripUpdateReceiver.java to kotlin
- [TripKit] convert RealTimeTripUpdateReceiver.java to kotlin
- [TripKit] convert ServiceExtras.java to kotlin
- [TripKit] convert Tables.java to kotlin
- [TripKit] convert TemporaryUrlApi.java to kotlin
- [TripKit] convert TransitService.java to kotlin
- [TripKit] convert TripKit.java to kotlin
- [TripKit] convert TripKitConfigs.java to kotlin
- [TripKit] convert TripPreferences.java to kotlin
- [TripKit] convert Utils.java to kotlin
- [TripKit] convert UuidProvider.java to kotlin
- [TripKitUI] update affected classes
@github-actions github-actions bot added the stale No updates, stale PR label Nov 17, 2024
@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Nov 19, 2024
@github-actions github-actions bot added the stale No updates, stale PR label Nov 25, 2024
@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Nov 26, 2024
@github-actions GitHub Actions
Copy link

❌ Unit tests failed!

@MichaelReyes, please review and fix the issues in the unit tests.

Test results are available under the "Artifacts" section of this run in GitHub Actions.

@MichaelReyes
[22037]
cfb1a28 
- [TripGov5] update Auth0AuthenticationService to fetch auth0 clientId from TripKitKeys
- [TripGov5] update odin configs.xml to remove secret keys
- [TripGov5] update UserItem and go_card_item_user_id.xml to include tripGoClientId parameter for loading image
- [TripGov5] update OnePassApplication to fetch skedgo api key from TripKitKeys
- [TripGov5] update settings_white_label.xml to change signout from Preference to CustomPreference
- [TripKitUI] update trip_result_list_item.xml and trip_result_list_item_trip.xml to set scrollIndicators to none
@github-actions GitHub Actions
Copy link

❌ Unit tests failed!

@MichaelReyes, please review and fix the issues in the unit tests.

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg-jsonjuliane sg-jsonjuliane sg-jsonjuliane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelReyes @sg-jsonjuliane