Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup state locking and make JSON RPC calls like eth_call faster #1545

Open
kladkogex opened this issue Jun 18, 2023 · 1 comment · May be fixed by #2046
Open

Cleanup state locking and make JSON RPC calls like eth_call faster #1545

kladkogex opened this issue Jun 18, 2023 · 1 comment · May be fixed by #2046
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kladkogex
Copy link
Collaborator

kladkogex commented Jun 18, 2023

Our current State locks are really convoluted and error prone.
They can potentially lead to performance degradation.

In particular Also eth_calls interfere with block commit. When there are many eth_call
requests, a block can not be committed since they fight for the same state lock.

@kladkogex kladkogex added this to the 2.3 milestone Jun 18, 2023
@kladkogex kladkogex self-assigned this Jun 18, 2023
@DmytroNazarenko DmytroNazarenko added enhancement New feature or request Technical debt and removed enhancement New feature or request labels Jun 27, 2023
@DmytroNazarenko DmytroNazarenko modified the milestones: 2.3, SKALE 2.3 Jul 4, 2023
@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 Sep 8, 2023
@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.3, SKALE 2.4 Nov 15, 2023
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to To Do in SKALE Engineering 🚀 Dec 15, 2023
@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 Jan 25, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to To Do in SKALE Engineering 🚀 Jan 25, 2024
@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 Jan 25, 2024
@kladkogex kladkogex modified the milestones: SKALE 2.4, SKALE 2.5 Mar 21, 2024
@kladkogex
Copy link
Collaborator Author

Moving to 2.5 since we do not have time for this in 2.4

@kladkogex kladkogex changed the title Cleanup state locking in 2.3 Cleanup state locking and make read JSON RPC calls like eth_call faster May 17, 2024
@kladkogex kladkogex changed the title Cleanup state locking and make read JSON RPC calls like eth_call faster Cleanup state locking and make JSON RPC calls like eth_call faster May 17, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 May 27, 2024
kladkogex added a commit that referenced this issue Jun 21, 2024
kladkogex added a commit that referenced this issue Jun 21, 2024
kladkogex added a commit that referenced this issue Jun 21, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 17, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 22, 2024
kladkogex added a commit that referenced this issue Jul 23, 2024
kladkogex added a commit that referenced this issue Jul 23, 2024
@kladkogex kladkogex linked a pull request Sep 12, 2024 that will close this issue
@DmytroNazarenko DmytroNazarenko added the enhancement New feature or request label Sep 27, 2024
@kladkogex kladkogex linked a pull request Nov 25, 2024 that will close this issue
@PolinaKiporenko PolinaKiporenko moved this from In Progress to Code Review in SKALE Engineering 🚀 Dec 9, 2024
olehnikolaiev added a commit that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

3 participants