State::updateToLatestVersion() does not update historic state

[dimalit]

This would fail:

    State state(...);

    State writer = state.createStateModifyCopy();
    < change writer state >
    writer.commit( dev::eth::CommitBehaviour::RemoveEmptyAccounts );
    writer.mutableHistoricState().saveRootForBlock(1);
    writer.mutableHistoricState().setRootByBlockNumber(1);

    State sr = state.createStateReadOnlyCopy();
    < check that sr.mutableHistoricState() has updated data >

This is detectable only in tests, but it looks like inconsistency

[kladkogex]

Hey guys

The version does not exist anymore in the pull request that I am preparing for 3.1, so I am going to close this bug if there is no objection

State::updateToLatestVersion()

[dimalit]

In our new (snapshot-based) State architecture, Client::restartMining() calls State::createStateCopyAndClearCaches();

But actually, to work correctly, restartMining() should ensure that State is in sync with latest changes in the DB. So, it needs:

1. state root in HistoricState updated to latest block;
2. correct values of storageUsed;
3. maybe something else (to research)

[kladkogex]

Ok - I will check