Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add removed field to eth_getLogs response #1986

Open
olehnikolaiev opened this issue Sep 11, 2024 · 0 comments
Open

add removed field to eth_getLogs response #1986

olehnikolaiev opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working epic:eth-compatibility
Milestone

Comments

@olehnikolaiev
Copy link
Contributor

in order to be fully compatible with geth we need to change the template response for eth_getLogs request.

skaled response:

> eth.getLogs({'fromBlock': '0x12e9', 'toBlock': '0x12ee'})
[{
    address: "0x19a03b2f1cc661cffb83123c37bfa009f6b9280b",
    blockHash: "0x1ac5188a70e4253c204c81d0229443a7241fe8acb5304c6f8253a0068b1de091",
    blockNumber: "0x12ed",
    data: "0x",
    logIndex: "0x0",
    polarity: true,
    topics: ["0xc4afcd8d38f903c1c3c8ab41a84f6df29cb7fb88e0d7121bc9633c15eb94af86", "0x0000000000000000000000008f07a578631dabf756fdf55df751c66a95044696", "0x00000000000000000000000000000000000000000000000000005af3107a4000", "0x0000000000000000000000000000000000000000000000000000000066e1cc85"],
    transactionHash: "0xcf632d036e972fee66c4d5ec5291a27474145b01dbe289a7fc8ab222089b063f",
    transactionIndex: "0x0",
    type: "mined"
}

geth response:

{
    address: "0x6915f36939e616ed8752e372ee217b45ed68b7ad",
    blockHash: "0xe1326f2f16a3419f0030d0171bcc3cdaaa36d65a583a075bda0f4d8de4da6917",
    blockNumber: "0x65b411",
    data: "0x00000000000000000000000000000000000000000000003635c9adc5dea00000",
    logIndex: "0x31",
    removed: false,
    topics: ["0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef", "0x0000000000000000000000000000000000000000000000000000000000000000", "0x0000000000000000000000009dcd12b5f605e17ca7849088b2e9d8440ab9b95c"],
    transactionHash: "0xe15257b06544c34e68d28d3718b108d4910589b1bd0b4ae5a8bb1e56d68ea5e4",
    transactionIndex: "0x2b"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic:eth-compatibility
Projects
Status: No status
Development

No branches or pull requests

2 participants