Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect exit in the middle of block execution #775

Closed
dimalit opened this issue May 4, 2023 · 4 comments · Fixed by #777
Closed

Incorrect exit in the middle of block execution #775

dimalit opened this issue May 4, 2023 · 4 comments · Fixed by #777
Assignees
@kladkogex
Labels
bug Something isn't working release:2.2

Comments

@dimalit
Copy link
Contributor

dimalit commented May 4, 2023

Actual:

  1. 4 nodes
  2. exitGracefully() is called inside createBlock()
  3. createBlock() doesn't return for 40 sec (for testing)
  4. consensus outputs No luck exiting on block boundary. Exiting immediately

Expected:
consensus should not include time, when it was waiting for skaled, in it's own timeout - and in this case should not consider this exit as "not on block boundary"
@kladkogex
Copy link
Contributor

Lets discuss exactly

@kladkogex kladkogex self-assigned this May 16, 2023
@kladkogex kladkogex added this to the 2.2 milestone May 16, 2023
@kladkogex kladkogex moved this to Code Review in SKALE Engineering 🚀 May 16, 2023
@kladkogex kladkogex linked a pull request May 16, 2023 that will close this issue
774 and 775 incorrect exit #777
Merged
@DmytroNazarenko DmytroNazarenko added the bug Something isn't working label May 18, 2023
@DmytroNazarenko DmytroNazarenko removed this from the 2.2 milestone May 18, 2023
@DmytroNazarenko
Copy link
Contributor

Related to skalenetwork/skaled#1425

@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 May 22, 2023
@DmytroNazarenko
Copy link
Contributor

skaled: 3.17.0-beta.1

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jun 21, 2023
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jun 21, 2023
@oleksandrSydorenkoJ
Copy link

Verified on
skalenetwork/schain:3.17.0-beta.7-historic

Skaled wait for 270 seconds of the gracefully timeout after sigterm if consensus stuck during block processing

historic_block_call_during_proccessing_transactions.log

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kladkogex kladkogex

Labels
bug Something isn't working release:2.2
Projects
SKALE Engineering 🚀
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

774 and 775 incorrect exit skalenetwork/skale-consensus
4 participants
@dimalit @kladkogex @DmytroNazarenko @oleksandrSydorenkoJ