From fc308fa995b2fbd83faf1857a984e7f04de37713 Mon Sep 17 00:00:00 2001 From: badrogger Date: Fri, 11 Oct 2024 12:13:44 +0000 Subject: [PATCH] Fix update_sync test --- node_cli/core/node.py | 3 --- tests/cli/sync_node_test.py | 19 ++----------------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/node_cli/core/node.py b/node_cli/core/node.py index e073081d..da06a11d 100644 --- a/node_cli/core/node.py +++ b/node_cli/core/node.py @@ -219,9 +219,6 @@ def init_sync( @check_inited @check_user def update_sync(env_filepath: str, unsafe_ok: bool = False) -> None: - if not unsafe_ok and not is_update_safe(): - error_msg = 'Cannot update safely' - error_exit(error_msg, exit_code=CLIExitCodes.UNSAFE_UPDATE) logger.info('Node update started') configure_firewall_rules() env = get_node_env(env_filepath, sync_node=True) diff --git a/tests/cli/sync_node_test.py b/tests/cli/sync_node_test.py index 84b4a423..4431a0a6 100644 --- a/tests/cli/sync_node_test.py +++ b/tests/cli/sync_node_test.py @@ -25,10 +25,9 @@ from node_cli.configs import SKALE_DIR, NODE_DATA_PATH from node_cli.core.node_options import NodeOptions from node_cli.cli.sync_node import _init_sync, _update_sync -from node_cli.utils.exit_codes import CLIExitCodes from node_cli.utils.helper import init_default_logger -from tests.helper import run_command, safe_update_api_response, subprocess_run_mock +from tests.helper import run_command, subprocess_run_mock from tests.resources_test import BIG_DISK_SIZE logger = logging.getLogger(__name__) @@ -107,18 +106,4 @@ def test_update_sync(mocked_g_config): 'node_cli.utils.decorators.is_node_inited', return_value=True ): result = run_command(_update_sync, ['./tests/test-env', '--yes']) - assert result.exit_code == CLIExitCodes.UNSAFE_UPDATE - assert 'Cannot update safely' in result.output - - with mock.patch( - 'node_cli.utils.helper.requests.get', return_value=safe_update_api_response() - ): - result = run_command(_update_sync, ['./tests/test-env', '--yes']) - assert result.exit_code == 0 - - with mock.patch( - 'node_cli.utils.helper.requests.get', return_value=safe_update_api_response(False) - ): - result = run_command(_update_sync, ['./tests/test-env', '--yes']) - assert result.exit_code == CLIExitCodes.UNSAFE_UPDATE - assert 'Cannot update safely' in result.output + assert result.exit_code == 0