Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary assembly #1296

Open
DimaStebaev opened this issue Oct 4, 2022 · 0 comments
Open

Remove unnecessary assembly #1296

DimaStebaev opened this issue Oct 4, 2022 · 0 comments
Assignees

Comments

@DimaStebaev
Copy link
Contributor

https://github.com/skalenetwork/IMA/blob/1.3.4-beta.1/proxy/contracts/schain/KeyStorage.sol#L112

Using of pure assembly is dangerous and in the case can be easily replaced nether by pure solidity syntax or more robust openzeppelin wrapper.

Another even more dangerous using of assembly is never used and can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants