Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If IMA was upgraded on SKALE chain connectSchain function works incorrectly #1168

Open
DimaStebaev opened this issue Jun 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@DimaStebaev
Copy link
Contributor

TokenManagerLinker has a function connectSchain that setup interaction between token managers and message proxies.
For each registered token manager it sets address of receiver of it's message. Now it's assumed that all token managers are predeployed and have the same addresses. But this invariant is violated after IMA upgrade.

For example recently TokenManagerERC721WithMetadata was introduced and it has different address on brand new SKALE chains and on upgraded ones what means that if a new chain is connected to old one or vice versa the token managers is not properly connected.

To Reproduce
Steps to reproduce the behavior:

  1. Start SKALE chain with old version of IMA
  2. Start SKALE chain with new version of IMA
  3. Update IMA on the first chain
  4. Call a connectSchain function of TokenManagerLinker to connect two chains

Expected behavior
ERC721WithMetadata can be transferred between chains

Additional context
The problem will be relevant for all new token managers or IMA instances that will not be predeployed.

@DimaStebaev DimaStebaev added the bug Something isn't working label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant