Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions #1

Open
yatish27 opened this issue Apr 8, 2017 · 0 comments
Open

Suggestions #1

yatish27 opened this issue Apr 8, 2017 · 0 comments

Comments

@yatish27
Copy link

yatish27 commented Apr 8, 2017 •
edited
Loading

  • Do you think we can make the interface for controller actions simple? We can use context rather than the typical request and response.
  • Can you use SQLite to show db interaction? This will make it more real world usable
  • Can you add comments to app.go like where/how to add routes, middlewares? Maybe a usage comment. Add multiple middlewares and routes and comment them.
  • Create a section in README about the different shoulder packages you are using in this repo
  • In users_routes.go can you add a comment for what the actual route will be. eg what is the url for get_all action(v1/users/get_all) ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yatish27