Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

文档图标支持使用网络链接 #12926

Open
88250 opened this issue Oct 26, 2024 · 8 comments
Open

文档图标支持使用网络链接 #12926

88250 opened this issue Oct 26, 2024 · 8 comments
Assignees
@88250 @Vanessa219
Labels
Enhancement
Milestone
backlog

Comments

@88250
Copy link
Member

88250 commented Oct 26, 2024

No description provided.

@88250 88250 added this to the 3.1.11 milestone Oct 26, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Oct 26, 2024

关联 #12119 ，希望也能支持 Base64，这样自定义图标就不需要非得有一个图标文件存在本地文件夹里了

@88250
Copy link
Member Author

88250 commented Oct 27, 2024

@TCOTC 不考虑支持 Base64 编码嵌入图片，效率太低了。

@TCOTC
Copy link
Contributor

TCOTC commented Oct 27, 2024 •
edited
Loading

话说效率会比网络链接低吗？本地解码应该比请求网络资源快吧

@88250
Copy link
Member Author

88250 commented Oct 27, 2024

对数据解析压力较大，会严重影响编辑器性能。

@TCOTC
Copy link
Contributor

TCOTC commented Oct 27, 2024 •
edited
Loading

不考虑支持 Base64 编码嵌入图片

我是说文档图标，不是编辑器里的图片。

Notion 也只支持了文档图标使用 Base64

@88250
Copy link
Member Author

88250 commented Oct 27, 2024 •
edited
Loading

一样的，文档图标是存在属性里的，会影响编辑器性能。

@OpaqueGlass OpaqueGlass mentioned this issue Oct 27, 2024
Open
2 tasks
@siyuan-note siyuan-note deleted a comment Oct 28, 2024
@InayaWhoCodes
Copy link

+1

@Vanessa219
Copy link
Member

可以把上传和外链统一为添加自定义表情

QQ_1730346355112

@88250 88250 modified the milestones: 3.1.11, backlog Oct 31, 2024
@TCOTC TCOTC mentioned this issue Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
4 participants
@88250 @Vanessa219 @TCOTC @InayaWhoCodes