Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not loading the Rashi commentary, not sure how to activate that. #68

Closed
ibay770 opened this issue Jun 16, 2023 · 4 comments
Closed

Not loading the Rashi commentary, not sure how to activate that. #68

ibay770 opened this issue Jun 16, 2023 · 4 comments
Assignees

Comments

@ibay770
Copy link

ibay770 commented Jun 16, 2023

Problem

On this site, I tried using the next page setting, which works, but it doesn't load with Rashis commentary ( the url is set to true at the end but I don't know how to append the next page with that setting)
Thanks in advance.

URL

No response

Version

No response

Browser

No response

OS

No response

Device

None

@sixcious sixcious self-assigned this Jun 19, 2023
@sixcious
Copy link
Owner

Hi again Nossy!

OK, there's two things going on with that site:

  1. It's using a script to load its commentary so you'll need to use the regular Iframe append mode instead of Page to load that script for all appended pages.
  2. It only updates the next link to show the commentary for the link that's visible on the page (not the link that Infy tries to find automatically), so you'll need to explicitly give it a path to the specific link that it's updating to enable the commentary.

Try copy/pasting the below Save for that site and add to your Saves by going to Infy Scroll's Options > Saves > Add Save (if you already have a Save made for the site, you can delete or edit it):

{
  "action": "next",
  "append": "iframe",
  "name": "Chabad",
  "nextLink": "//a[@class='next_article']",
  "type": "regex",
  "url": "^https://www\\.chabad\\.org/library/bible_cdo/aid/"
}

Like I mentioned in #62 though, this is really the last time I can help you with a specific website. I'm just one person, and there's so many websites out there that I can't really (set a precedent to) provide support to everyone who needs help with a site (as much as I'd like to!). Thank you for understanding. 💜

I'm going to close this, but I really hope this helps. Thank you! 💜

@alexolog
Copy link

While I understand your reasoning, saying "this is really the last time I can help you with a specific website" sends the wrong message.
It will be better to give people a venue to ask for and to contribute entries, either via GitHub discussions or a link to an external forum.

@ibay770
Copy link
Author

ibay770 commented Jun 25, 2023

Just wanted to thank you again. You're right, it's true you are only one person and obviously you are not expected to help out, you have indeed done so much. The reason we turn to you is cuz you're the expert, it's like busy specialists that are always busy because they are so good.
Perhaps as @alexolog mentioned, perhaps make another discussion board where people can post problem sites and others can fix them.
Thank you again for everything.

@ibay770
Copy link
Author

ibay770 commented Jul 5, 2023

While I understand your reasoning, saying "this is really the last time I can help you with a specific website" sends the wrong message. It will be better to give people a venue to ask for and to contribute entries, either via GitHub discussions or a link to an external forum.
What would be a good forum to use for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants