From 0d1ad6d11b1360e918556e07d5013395d704c282 Mon Sep 17 00:00:00 2001 From: Alex S <17275120+AlexGStapleton@users.noreply.github.com> Date: Thu, 10 Feb 2022 23:56:54 +1000 Subject: [PATCH 1/3] Prevent Fixed Background Image Display on Tablets --- inc/styles.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/inc/styles.php b/inc/styles.php index 1b7c37ec3..3eee5138d 100644 --- a/inc/styles.php +++ b/inc/styles.php @@ -684,6 +684,14 @@ static function general_style_tablet_css( $css, $style ){ $css['padding'] = $style[ 'tablet_padding' ]; } + if ( + ! empty( $style['background_display'] ) && + $style['background_display'] == 'fixed' && + ! ( empty( $style['background_image_attachment'] ) && empty( $style['background_image_attachment_fallback'] ) ) + ) { + $css[ 'background-attachment' ] = 'scroll'; + } + return $css; } From c370f27044e26e1aa06d47ca21965144f2360ee6 Mon Sep 17 00:00:00 2001 From: Alex S <17275120+AlexGStapleton@users.noreply.github.com> Date: Thu, 10 Feb 2022 23:57:32 +1000 Subject: [PATCH 2/3] Allow row/cell/row wrapper to be set up if only `$tablet_css` exists --- inc/renderer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/renderer.php b/inc/renderer.php index 08f4d439c..34211b786 100644 --- a/inc/renderer.php +++ b/inc/renderer.php @@ -562,7 +562,7 @@ private function start_style_wrapper( $name, $style = array(), $for = false ) { } $style_wrapper = ''; - if ( ! empty( $attributes ) || ! empty( $standard_css ) || ! empty( $mobile_css ) ) { + if ( ! empty( $attributes ) || ! empty( $standard_css ) || ! empty( $tablet_css )|| ! empty( $mobile_css ) ) { if ( empty( $attributes['class'] ) ) { $attributes['class'] = array(); } From f8af19e9cffe4d9742fb87892659de23e833210d Mon Sep 17 00:00:00 2001 From: Andrew Misplon Date: Mon, 14 Feb 2022 11:41:15 +0200 Subject: [PATCH 3/3] Changelog update --- readme.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/readme.txt b/readme.txt index 4b19e87ca..65831970c 100644 --- a/readme.txt +++ b/readme.txt @@ -107,6 +107,9 @@ SiteOrigin Premium includes access to our professional email support service, pe == Changelog == += 2.16.3 - 14 February 2022 = +* Fixed Background Images: Change to `scroll` on mobile devices. Resolves iOS bug. + = 2.16.2 - 07 February 2022 = * Added Yoast Video SEO plugin integration. * Restored content analysis functionality for newer Yoast SEO versions.