Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to test changes to the codebase? #506

Open
enlob opened this issue Apr 1, 2024 · 4 comments
Open

How to test changes to the codebase? #506

enlob opened this issue Apr 1, 2024 · 4 comments

Comments

@enlob
Copy link

enlob commented Apr 1, 2024

Question

Hi, I wish to contribute to this project but I'm finding it difficult to test the included test apps against my local changes.
Right now it looks like test apps are correctly loading angular dependencies as externals.

image

And according to the importmap, the dependencies are fetched from the cdn.

image

What is the correct approach to load the local library instead (under /lib)?

@enlob
Copy link
Author

enlob commented May 14, 2024

@arturovt could you please point me in the right direction?

@arturovt
Copy link
Collaborator

I don't remember exactly, as far as I recall I used to serve it locally through the root app Webpack's config...

@enlob
Copy link
Author

enlob commented May 25, 2024

@arturovt thank you for your answer. Are you able to elaborate a little bit more on that? Did you use something like rollup to build systemjs modules from fesm modules and then maybe http-server to serve them locally, and changed the root app importmap to point to the locally served modules?

@arturovt
Copy link
Collaborator

Yes, I'll go over the integration locally and provide you with steps on debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants