Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications filtering does not work with GitHub Teams #239

Open
xakraz opened this issue Jan 7, 2021 · 4 comments
Open

Notifications filtering does not work with GitHub Teams #239

xakraz opened this issue Jan 7, 2021 · 4 comments

Comments

@xakraz
Copy link

xakraz commented Jan 7, 2021

Hi there !

According to this comment notifier-for-github use the https://api.github.com/user/repos endpoint with the users token to get a list of repos that the user has access to.

This works like a charm !

I am using GitHub in my company and this extension would be so useful for me.
Unfortunately, the filtering capability does not work when you are part of a GitHub team that as access to a repo.

@notlmn
Copy link
Collaborator

notlmn commented Jan 9, 2021

Hey Xavier, can you clarify on what you mean by "GitHub team that has access to a repo"?

We do have enterprise support if that is what you mean if your company has self-hosted GitHub server at github.my-random-company.com.

Unfortunately the only limitation right now is you can't use this extension with public GitHub instance, and private company instance at the same time (the API token would be different for each of them).

If you are referring only to the public GitHub instance, https://api.github.com/user/repos gives us list of repos that you are "watching" on, not repos that you have "access" to, i.e., you can have write access to a repo but not be watching it.

You'll find the repos that you watching at https://github.com/watching, which is basically what the API provides us.

@xakraz
Copy link
Author

xakraz commented Feb 8, 2021

Hi @notlmn ,

I apologize for the delay of my answer.

We are not using a self-hosted GitHub server, we are using GitHub.com services with a specific plan for our company.

Thanks for the tips regarding the "watiching" stuff. I will give it a try this week and provide feedback.

@amaisano
Copy link

Same - I am part of an organization that has some private repos on it. They never appear in the extension list. Is this possible?

@positonic
Copy link

Same question as above, if you guys gave some guidance I'd be happy to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants