Failed to load URL: app://-/ with error: ERR_FILE_NOT_FOUND

[itsonlyjames]

Completely stumped here and seeking some help—I've updated to the latest version and so am now using imports instead of requires.

Nothing else has changed except for updating the relevant packages and changing from require to import, yet I'm receiving this error..

I did investigate #29 however that seems due to a change in build structure, whereas none of my structure has changed. I do see it being from a long time ago however.

Here is my minimal electron.js reproducible code:

const __filename = fileURLToPath(import.meta.url)
const __dirname = dirname(__filename)

const serveURL = serve({ directory: './' })
let mainWindow

function createWindow() {
    let windowState = windowStateManager({
        defaultWidth: 800,
        defaultHeight: 600
    })

    const mainWindow = new BrowserWindow({
        backgroundMaterial: 'none',
        backgroundColor: 'rgba(0,0,0,0)',
        titleBarStyle: process.platform === 'darwin' ? 'hidden' : 'default',
        autoHideMenuBar: true,
        trafficLightPosition: {
            x: 14,
            y: 14
        },
        center: true,
        minHeight: 450,
        minWidth: 500,
        webPreferences: {
            contextIsolation: true,
            spellcheck: false,
            devTools: true,
            preload: path.join(__dirname, 'preload.cjs')
        },
        icon: path.join(__dirname, '../static/icon.png'),
        x: windowState.x,
        y: windowState.y,
        width: windowState.width,
        height: windowState.height
    })

    windowState.manage(mainWindow)

    mainWindow.once('ready-to-show', () => {
        mainWindow.show()
        mainWindow.focus()
    })

    mainWindow.on('close', () => {
        windowState.saveState(mainWindow)
    })

    mainWindow.webContents.session.protocol.registerFileProtocol(
        'media',
        (request, callback) => {
            const pathname = decodeURIComponent(
                request.url.replace('media://', '')
            )
            callback(pathname)
        }
    )

    mainWindow.webContents.setWindowOpenHandler(({ url }) => {
        shell.openExternal(url)
        return { action: 'deny' }
    })

    return mainWindow
}

async function loadStatic(mainWindow) {
    await serveURL(mainWindow)
        .then((url) => {
            mainWindow.loadURL(url)
        })
        .catch((e) => {
            console.log('Error: ', e)
        })
}

async function createMainWindow() {
    mainWindow = createWindow()
    mainWindow.once('close', () => {
        mainWindow = null
    })
    await loadStatic(mainWindow)
}

Build.config

{
  "directories": {
    "output": "../dist"
  },
  "files": [
    "src/electron.js",
    "src/preload.cjs",
    "!**/ffprobe-static/bin/**/*",
    "**/ffprobe-static/bin/${platform}/${arch}/ffprobe",
    {
      "from": "build",
      "to": ""
    }
  ],
  "mac": {
    "icon": "icon.png"
  }
}

Directory structure:

.
├── Client/
│   ├── build/
│   │   ├── _app/
│   │   └── index.html
│   ├── src/
│   │   ├── app.html
│   │   ├── electron.js
│   │   └── preload.cjs
│   └── build.config.json
└── dist/

Any help is greatly appreciated!

[k7sleeper]

That's due to line 42 of index.js:

const isSafe = relativePath && !relativePath.startsWith('..') && !path.isAbsolute(relativePath);

should be changed to

const isSafe = !relativePath.startsWith('..') && !path.isAbsolute(relativePath);

as relativePath can never be null or undefined but is '' for the first request.

You may also change line 42 to

const isSafe = relativePath != null && !relativePath.startsWith('..') && !path.isAbsolute(relativePath);

[itsonlyjames]

@k7sleeper that suggestion works for me and I thank you for that.

Ought this be a fix in the codebase?

[k7sleeper]

@itsonlyjames Yes, This should be a fix.

[itsonlyjames]

@k7sleeper #45