[Feedback] HttpClient usage does not follow best practice

[thegrahamking]

Given that the guidance is to create SinchClient as a singleton (see "With ASP.NET dependency injection") the HttpClient instance created if one is not specified via options.HttpClient or one that is captured by setting options.HttpClient in the singleton factory delegate will not obtain DNS updates and high throughput could exhaust the OS limit of available ports.

See

• https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines
• https://learn.microsoft.com/en-us/dotnet/core/extensions/httpclient-factory#httpclient-lifetime-management
• https://learn.microsoft.com/en-us/dotnet/core/extensions/httpclient-factory

Suggestion

Replace options.HttpClient with options.HttpClientFactory and create and dispose HttpClient instances from the factory as needed.

[Dovchik]

Thanks for your insight @thegrahamking, I'll take a look at what can be done and implemented into the client.