fix(workflows): ignore nonfatal mcp sync failures

Author: PlaneInABottle

apps/sim/app/api/workflows/[id]/deploy/route.test.ts

@@ -191,6 +191,36 @@ describe('Workflow deploy route', () => {
     )
   })
 
+  it('returns success when MCP sync throws after deploy succeeds', async () => {
+    mockValidateWorkflowAccess.mockResolvedValue({
+      workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },
+      auth: {
+        success: true,
+        userId: 'api-user',
+        userName: 'API Key Actor',
+        userEmail: 'api@example.com',
+        authType: 'api_key',
+      },
+    })
+    mockDeployWorkflow.mockResolvedValue({
+      success: true,
+      deployedAt: '2024-01-01T00:00:00Z',
+      deploymentVersionId: 'dep-1',
+    })
+    mockSyncMcpToolsForWorkflow.mockRejectedValue(new Error('MCP sync failed'))
+
+    const req = new NextRequest('http://localhost:3000/api/workflows/wf-1/deploy', {
+      method: 'POST',
+      headers: { 'x-api-key': 'test-key' },
+    })
+    const response = await POST(req, { params: Promise.resolve({ id: 'wf-1' }) })
+
+    expect(response.status).toBe(200)
+    const data = await response.json()
+    expect(data.isDeployed).toBe(true)
+    expect(mockRecordAudit).toHaveBeenCalled()
+  })
+
   it('allows API-key auth for undeploy using hybrid auth userId', async () => {
     mockValidateWorkflowAccess.mockResolvedValue({
       workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },

apps/sim/app/api/workflows/[id]/deploy/route.ts

@@ -242,8 +242,13 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
 
     logger.info(`[${requestId}] Workflow deployed successfully: ${id}`)
 
-    // Sync MCP tools with the latest parameter schema
-    await syncMcpToolsForWorkflow({ workflowId: id, requestId, context: 'deploy' })
+    try {
+      await syncMcpToolsForWorkflow({ workflowId: id, requestId, context: 'deploy' })
+    } catch (syncError) {
+      logger.error(`[${requestId}] Failed to sync MCP tools after deploy for workflow ${id}`, {
+        error: syncError,
+      })
+    }
 
     const { actorName, actorEmail } = getAuditActorMetadata(auth)
 

apps/sim/app/api/workflows/[id]/deployments/[version]/revert/route.test.ts

@@ -224,4 +224,29 @@ describe('Workflow deployment version revert route', () => {
       })
     )
   })
+
+  it('returns success when MCP sync throws after revert succeeds', async () => {
+    mockValidateWorkflowAccess.mockResolvedValue({
+      workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },
+      auth: {
+        success: true,
+        userId: 'api-user',
+        userName: 'API Key Actor',
+        userEmail: 'api@example.com',
+        authType: 'api_key',
+      },
+    })
+    mockSyncMcpToolsForWorkflow.mockRejectedValue(new Error('MCP sync failed'))
+
+    const req = new NextRequest('http://localhost:3000/api/workflows/wf-1/deployments/3/revert', {
+      method: 'POST',
+      headers: { 'x-api-key': 'test-key' },
+    })
+    const response = await POST(req, { params: Promise.resolve({ id: 'wf-1', version: '3' }) })
+
+    expect(response.status).toBe(200)
+    const data = await response.json()
+    expect(data.message).toBe('Reverted to deployment version')
+    expect(mockRecordAudit).toHaveBeenCalled()
+  })
 })

apps/sim/app/api/workflows/[id]/deployments/[version]/revert/route.ts

@@ -103,12 +103,18 @@ export async function POST(
       .set({ lastSynced: new Date(), updatedAt: new Date() })
       .where(eq(workflow.id, id))
 
-    await syncMcpToolsForWorkflow({
-      workflowId: id,
-      requestId,
-      state: deployedState,
-      context: 'revert',
-    })
+    try {
+      await syncMcpToolsForWorkflow({
+        workflowId: id,
+        requestId,
+        state: deployedState,
+        context: 'revert',
+      })
+    } catch (syncError) {
+      logger.error(`[${requestId}] Failed to sync MCP tools after revert for workflow ${id}`, {
+        error: syncError,
+      })
+    }
 
     try {
       const socketServerUrl = env.SOCKET_SERVER_URL || 'http://localhost:3002'

apps/sim/app/api/workflows/[id]/deployments/[version]/route.test.ts

@@ -204,6 +204,32 @@ describe('Workflow deployment version route', () => {
     )
   })
 
+  it('returns success when MCP sync throws after activation succeeds', async () => {
+    mockValidateWorkflowAccess.mockResolvedValue({
+      workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },
+      auth: {
+        success: true,
+        userId: 'api-user',
+        userName: 'API Key Actor',
+        userEmail: 'api@example.com',
+        authType: 'api_key',
+      },
+    })
+    mockSyncMcpToolsForWorkflow.mockRejectedValue(new Error('MCP sync failed'))
+
+    const req = new NextRequest('http://localhost:3000/api/workflows/wf-1/deployments/3', {
+      method: 'PATCH',
+      headers: { 'content-type': 'application/json', 'x-api-key': 'test-key' },
+      body: JSON.stringify({ isActive: true }),
+    })
+    const response = await PATCH(req, { params: Promise.resolve({ id: 'wf-1', version: '3' }) })
+
+    expect(response.status).toBe(200)
+    const data = await response.json()
+    expect(data.success).toBe(true)
+    expect(mockRecordAudit).toHaveBeenCalled()
+  })
+
   it('returns write auth failure before parsing or updating metadata', async () => {
     mockValidateWorkflowAccess.mockResolvedValue({
       error: { message: 'Write permission required', status: 403 },

apps/sim/app/api/workflows/[id]/deployments/[version]/route.ts

@@ -271,12 +271,19 @@ export async function PATCH(
         }
       }
 
-      await syncMcpToolsForWorkflow({
-        workflowId: id,
-        requestId,
-        state: versionRow.state,
-        context: 'activate',
-      })
+      try {
+        await syncMcpToolsForWorkflow({
+          workflowId: id,
+          requestId,
+          state: versionRow.state,
+          context: 'activate',
+        })
+      } catch (syncError) {
+        logger.error(
+          `[${requestId}] Failed to sync MCP tools after activation for workflow ${id}`,
+          syncError
+        )
+      }
 
       // Apply name/description updates if provided alongside activation
       let updatedName: string | null | undefined