fix(slack): keep channel listing independent of credential storage

Author: icecrasher321

apps/docs/content/docs/integrations/slack.mdx

@@ -956,15 +956,15 @@ Rename the Slack agent session associated with a thread.
 
 ### Slack List Channels
 
-List accessible Slack conversations. Credential-group user tokens also return one-to-one and group direct messages.
+List accessible public and private Slack channels.
 
 #### Input
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
 | `authMethod` | string | No | Authentication method: oauth or bot_token |
 | `botToken` | string | No | Bot token for Custom Bot |
-| `includePrivate` | boolean | No | Include private channels the bot is a member of \(default: true\) |
+| `includePrivate` | boolean | No | Include private channels the connected account can access \(default: true\) |
 | `excludeArchived` | boolean | No | Exclude archived channels \(default: true\) |
 | `limit` | number | No | Maximum number of channels to return \(default: 100, max: 200\) |
 | `cursor` | string | No | Pagination cursor from a previous response.next_cursor |
@@ -973,7 +973,7 @@ List accessible Slack conversations. Credential-group user tokens also return on
 
 | Parameter | Type | Description |
 | --------- | ---- | ----------- |
-| `channels` | array | Accessible public and private channels, plus direct and group DMs for credential-group user tokens |
+| `channels` | array | Accessible public and private channels |
 |   ↳ `id` | string | Conversation ID \(for example, C123, D123, or G123\) |
 |   ↳ `name` | string | Channel or group-DM name; omitted for one-to-one direct messages |
 |   ↳ `is_channel` | boolean | Whether this is a channel |
@@ -997,8 +997,8 @@ List accessible Slack conversations. Credential-group user tokens also return on
 |   ↳ `is_user_deleted` | boolean | Whether the other participant in a direct message is deactivated |
 |   ↳ `is_open` | boolean | Whether a direct or group-direct-message conversation is open |
 |   ↳ `priority` | number | Slack sidebar sort priority |
-| `ids` | array | Conversation IDs for every returned channel or DM |
-| `names` | array | Names of returned channels and group DMs; one-to-one DMs have no name |
+| `ids` | array | Conversation IDs for every returned channel |
+| `names` | array | Names of returned channels |
 | `count` | number | Total number of conversations returned |
 | `nextCursor` | string | Cursor for the next page; null if no more pages |
 

apps/sim/tools/generated/tool-metadata.ts

@@ -17,27 +17,16 @@ function requestUrl(params: SlackListChannelsParams): URL {
 }
 
 describe('Slack list channels', () => {
-  it('includes direct and group DMs only for credential-group OAuth users', () => {
-    expect(requestUrl(BASE_PARAMS).searchParams.get('types')).toBe('public_channel,private_channel')
-    expect(requestUrl({ ...BASE_PARAMS, credentialType: 'oauth' }).searchParams.get('types')).toBe(
-      'public_channel,private_channel'
-    )
-    expect(
-      requestUrl({ ...BASE_PARAMS, credentialType: 'service_account' }).searchParams.get('types')
-    ).toBe('public_channel,private_channel')
-    expect(
-      requestUrl({ ...BASE_PARAMS, credentialType: 'managed_oauth' }).searchParams.get('types')
-    ).toBe('public_channel,private_channel,im,mpim')
-  })
-
-  it('keeps the private-channel toggle independent from managed DM access', () => {
-    const url = requestUrl({
-      ...BASE_PARAMS,
-      credentialType: 'managed_oauth',
-      includePrivate: false,
-    })
-    expect(url.searchParams.get('types')).toBe('public_channel,im,mpim')
-  })
+  it.each([undefined, 'oauth', 'managed_oauth', 'service_account'])(
+    'does not request DM scopes based on credential storage type %s',
+    (credentialType) => {
+      const params = { ...BASE_PARAMS, credentialType }
+      expect(requestUrl(params).searchParams.get('types')).toBe('public_channel,private_channel')
+      expect(requestUrl({ ...params, includePrivate: false }).searchParams.get('types')).toBe(
+        'public_channel'
+      )
+    }
+  )
 
   it('rejects invalid limits and empty cursors before the provider request', () => {
     expect(() => requestUrl({ ...BASE_PARAMS, limit: 0 })).toThrow(

apps/sim/tools/generated/tool-outputs.ts

@@ -84,16 +84,14 @@ export const slackListChannelsTool: ToolConfig<SlackListChannelsParams, SlackLis
   {
     id: 'slack_list_channels',
     name: 'Slack List Channels',
-    description:
-      'List accessible Slack conversations. Credential-group user tokens also return one-to-one and group direct messages.',
+    description: 'List accessible public and private Slack channels.',
     version: '1.1.0',
 
     oauth: {
       required: true,
       provider: 'slack',
       /** Slack enforces the required scope for the target conversation type. */
       requiredScopes: [],
-      authoritativeParams: ['credentialType'],
     },
 
     params: {
@@ -115,17 +113,11 @@ export const slackListChannelsTool: ToolConfig<SlackListChannelsParams, SlackLis
         visibility: 'hidden',
         description: 'OAuth access token or bot token for Slack API',
       },
-      credentialType: {
-        type: 'string',
-        required: false,
-        visibility: 'hidden',
-        description: 'Credential type supplied by authorized token resolution',
-      },
       includePrivate: {
         type: 'boolean',
         required: false,
         visibility: 'user-or-llm',
-        description: 'Include private channels the bot is a member of (default: true)',
+        description: 'Include private channels the connected account can access (default: true)',
       },
       excludeArchived: {
         type: 'boolean',
@@ -154,9 +146,6 @@ export const slackListChannelsTool: ToolConfig<SlackListChannelsParams, SlackLis
         if (resolveBooleanParam(params.includePrivate, 'Include private channels', true)) {
           conversationTypes.push('private_channel')
         }
-        if (params.credentialType === 'managed_oauth') {
-          conversationTypes.push('im', 'mpim')
-        }
         url.searchParams.set('types', conversationTypes.join(','))
         url.searchParams.set(
           'exclude_archived',
@@ -204,21 +193,20 @@ export const slackListChannelsTool: ToolConfig<SlackListChannelsParams, SlackLis
     outputs: {
       channels: {
         type: 'array',
-        description:
-          'Accessible public and private channels, plus direct and group DMs for credential-group user tokens',
+        description: 'Accessible public and private channels',
         items: {
           type: 'object',
           properties: CONVERSATION_LIST_OUTPUT_PROPERTIES,
         },
       },
       ids: {
         type: 'array',
-        description: 'Conversation IDs for every returned channel or DM',
+        description: 'Conversation IDs for every returned channel',
         items: { type: 'string', description: 'Slack conversation ID' },
       },
       names: {
         type: 'array',
-        description: 'Names of returned channels and group DMs; one-to-one DMs have no name',
+        description: 'Names of returned channels',
         items: { type: 'string', description: 'Slack conversation name' },
       },
       count: {

apps/sim/tools/slack/list_channels.test.ts

@@ -661,7 +661,6 @@ interface SlackBaseParams {
   authMethod: 'oauth' | 'bot_token'
   accessToken: string
   botToken: string
-  credentialType?: 'oauth' | 'managed_oauth' | 'service_account'
 }
 
 export type SlackAgentSessionStatus = 'active' | 'processing' | 'suspended' | 'closed'

apps/sim/tools/slack/list_channels.ts

@@ -22197,7 +22197,7 @@
         },
         {
           "name": "List Channels",
-          "description": "List accessible Slack conversations. Credential-group user tokens also return one-to-one and group direct messages."
+          "description": "List accessible public and private Slack channels."
         },
         {
           "name": "List Channel Members",