address more comments

Author: icecrasher321

apps/sim/app/api/tools/workday/create-prehire/route.ts

@@ -18,6 +18,7 @@ const RequestSchema = z.object({
   email: z.string().optional(),
   phoneNumber: z.string().optional(),
   address: z.string().optional(),
+  countryCode: z.string().optional(),
 })
 
 export async function POST(request: NextRequest) {
@@ -46,6 +47,13 @@ export async function POST(request: NextRequest) {
     const firstName = parts[0] ?? ''
     const lastName = parts.length > 1 ? parts.slice(1).join(' ') : ''
 
+    if (!lastName) {
+      return NextResponse.json(
+        { success: false, error: 'Legal name must include both a first name and last name' },
+        { status: 400 }
+      )
+    }
+
     const client = await createWorkdaySoapClient(
       data.tenantUrl,
       data.tenant,
@@ -96,7 +104,7 @@ export async function POST(request: NextRequest) {
           Name_Data: {
             Legal_Name_Data: {
               Name_Detail_Data: {
-                Country_Reference: wdRef('ISO_3166-1_Alpha-2_Code', 'US'),
+                Country_Reference: wdRef('ISO_3166-1_Alpha-2_Code', data.countryCode ?? 'US'),
                 First_Name: firstName,
                 Last_Name: lastName,
               },

apps/sim/app/api/tools/workday/get-compensation/route.ts

@@ -3,7 +3,7 @@ import { type NextRequest, NextResponse } from 'next/server'
 import { z } from 'zod'
 import { checkInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
-import { createWorkdaySoapClient } from '@/tools/workday/soap'
+import { createWorkdaySoapClient, extractRefId, type WorkdayReference } from '@/tools/workday/soap'
 
 export const dynamic = 'force-dynamic'
 
@@ -57,15 +57,35 @@ export async function POST(request: NextRequest) {
     const workerInner = workerData?.Worker_Data as Record<string, unknown> | undefined
     const compensationData = workerInner?.Compensation_Data as Record<string, unknown> | undefined
 
-    const rawPlans = compensationData?.Compensation_Plan_Assignment
-    const plansArray = (Array.isArray(rawPlans) ? rawPlans : rawPlans ? [rawPlans] : []) as Record<
-      string,
-      unknown
-    >[]
+    const mapPlan = (p: Record<string, unknown>) => ({
+      id: extractRefId(p.Compensation_Plan_Reference as WorkdayReference | undefined) ?? null,
+      planName:
+        (p.Compensation_Plan_Reference as Record<string, unknown> | undefined)?.attributes
+          ?.Descriptor ?? null,
+      amount: p.Amount ?? p.Per_Unit_Amount ?? p.Individual_Target_Amount ?? null,
+      currency: extractRefId(p.Currency_Reference as WorkdayReference | undefined) ?? null,
+      frequency: extractRefId(p.Frequency_Reference as WorkdayReference | undefined) ?? null,
+    })
 
-    const compensationPlans = plansArray.map((p) => ({
-      ...p,
-    }))
+    const planTypes = [
+      'Employee_Base_Pay_Plan_Assignment_Data',
+      'Employee_Salary_Unit_Plan_Assignment_Data',
+      'Employee_Bonus_Plan_Assignment_Data',
+      'Employee_Allowance_Plan_Assignment_Data',
+      'Employee_Commission_Plan_Assignment_Data',
+      'Employee_Stock_Plan_Assignment_Data',
+      'Employee_Period_Salary_Plan_Assignment_Data',
+    ] as const
+
+    const compensationPlans: ReturnType<typeof mapPlan>[] = []
+    for (const planType of planTypes) {
+      const raw = compensationData?.[planType]
+      if (!raw) continue
+      const arr = Array.isArray(raw) ? raw : [raw]
+      for (const p of arr) {
+        compensationPlans.push(mapPlan(p as Record<string, unknown>))
+      }
+    }
 
     return NextResponse.json({
       success: true,

apps/sim/blocks/blocks/workday.ts

@@ -144,6 +144,15 @@ export const WorkdayBlock: BlockConfig = {
       condition: { field: 'operation', value: 'create_prehire' },
       mode: 'advanced',
     },
+    {
+      id: 'countryCode',
+      title: 'Country Code',
+      type: 'short-input',
+      placeholder: 'US',
+      condition: { field: 'operation', value: 'create_prehire' },
+      mode: 'advanced',
+      description: 'ISO 3166-1 Alpha-2 country code (defaults to US)',
+    },
 
     // Hire Employee
     {
@@ -368,8 +377,12 @@ Output: {"businessTitle": "Senior Engineer"}`,
         }
 
         if (fields && operation === 'update_worker') {
-          const parsedFields = typeof fields === 'string' ? JSON.parse(fields) : fields
-          return { ...rest, fields: parsedFields }
+          try {
+            const parsedFields = typeof fields === 'string' ? JSON.parse(fields) : fields
+            return { ...rest, fields: parsedFields }
+          } catch {
+            throw new Error('Invalid JSON in Fields block')
+          }
         }
 
         return rest
@@ -389,6 +402,7 @@ Output: {"businessTitle": "Senior Engineer"}`,
     email: { type: 'string', description: 'Email address' },
     phoneNumber: { type: 'string', description: 'Phone number' },
     address: { type: 'string', description: 'Address' },
+    countryCode: { type: 'string', description: 'ISO 3166-1 Alpha-2 country code' },
     preHireId: { type: 'string', description: 'Pre-hire record ID' },
     positionId: { type: 'string', description: 'Position ID' },
     hireDate: { type: 'string', description: 'Hire date (YYYY-MM-DD)' },

apps/sim/components/icons.tsx

@@ -125,9 +125,11 @@ export function NoteIcon(props: SVGProps<SVGSVGElement>) {
 }
 
 export function WorkdayIcon(props: SVGProps<SVGSVGElement>) {
+  const id = useId()
+  const clipId = `workday_clip_${id}`
   return (
     <svg {...props} viewBox='0 0 64 64' fill='none' xmlns='http://www.w3.org/2000/svg'>
-      <g clipPath='url(#workday-clip)' transform='matrix(0.53333333,0,0,0.53333333,-124.63685,-16)'>
+      <g clipPath={`url(#${clipId})`} transform='matrix(0.53333333,0,0,0.53333333,-124.63685,-16)'>
         <path
           fillRule='evenodd'
           clipRule='evenodd'
@@ -142,7 +144,7 @@ export function WorkdayIcon(props: SVGProps<SVGSVGElement>) {
         />
       </g>
       <defs>
-        <clipPath id='workday-clip'>
+        <clipPath id={clipId}>
           <path d='M 354,30 H 234 v 120 h 120 z' fill='#ffffff' />
         </clipPath>
       </defs>

apps/sim/tools/workday/create_prehire.ts

@@ -63,6 +63,12 @@ export const createPrehireTool: ToolConfig<
       visibility: 'user-or-llm',
       description: 'Address of the pre-hire',
     },
+    countryCode: {
+      type: 'string',
+      required: false,
+      visibility: 'user-or-llm',
+      description: 'ISO 3166-1 Alpha-2 country code (defaults to US)',
+    },
   },
 
   request: {

apps/sim/tools/workday/types.ts

@@ -59,6 +59,7 @@ export interface WorkdayCreatePrehireParams extends WorkdayBaseParams {
   email?: string
   phoneNumber?: string
   address?: string
+  countryCode?: string
 }
 
 export interface WorkdayCreatePrehireResponse extends ToolResponse {