Skip to content

Commit 8453d4b

Browse files
waleedlatif1claude
andcommitted
fix(box): address PR review comments
- Fix docsLink for Box Sign: use underscore (box_sign) to match docs URL - Move normalizeFileInput from tool() to params() in Box block config to match Dropbox pattern - Throw error on invalid additionalSigners JSON instead of silently dropping signers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8bd8170 commit 8453d4b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

apps/sim/blocks/blocks/box.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -271,16 +271,14 @@ export const BoxBlock: BlockConfig = {
271271
'box_update_file',
272272
],
273273
config: {
274-
tool: (params) => {
274+
tool: (params) => `box_${params.operation}`,
275+
params: (params) => {
275276
const normalizedFile = normalizeFileInput(params.uploadFile || params.fileRef, {
276277
single: true,
277278
})
278279
if (normalizedFile) {
279280
params.file = normalizedFile
280281
}
281-
return `box_${params.operation}`
282-
},
283-
params: (params) => {
284282
const { credential, operation, ...rest } = params
285283

286284
const baseParams: Record<string, unknown> = {

apps/sim/blocks/blocks/box_sign.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export const BoxSignBlock: BlockConfig = {
1010
'Send documents for e-signature, check status, and manage sign requests with Box Sign',
1111
longDescription:
1212
'Integrate Box Sign into your workflow to send documents for e-signature. Create sign requests with multiple signers, track signing status, list all requests, cancel pending requests, and resend reminders. Ideal for offer letters, contracts, and other documents requiring signatures.',
13-
docsLink: 'https://docs.sim.ai/tools/box-sign',
13+
docsLink: 'https://docs.sim.ai/tools/box_sign',
1414
category: 'tools',
1515
bgColor: '#0061D5',
1616
icon: BoxCompanyIcon,

apps/sim/tools/box_sign/create_request.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ export const boxSignCreateRequestTool: ToolConfig<BoxSignCreateRequestParams, Bo
147147
signers.push(...additional)
148148
}
149149
} catch {
150-
// Ignore parse errors for additional signers
150+
throw new Error(
151+
'Invalid JSON in additionalSigners. Expected a JSON array of signer objects.'
152+
)
151153
}
152154
}
153155

0 commit comments

Comments
 (0)