fix(oracledb): address review feedback

Author: Bill Leoutsakos

apps/docs/components/icons.tsx

@@ -9276,7 +9276,7 @@ export function NewRelicIcon(props: SVGProps<SVGSVGElement>) {
   )
 }
 
-export function NetSuiteIcon(props: SVGProps<SVGSVGElement>) {
+function OracleOvalMark(props: SVGProps<SVGSVGElement>) {
   return (
     <svg {...props} viewBox='0 0 93.9 59.4' xmlns='http://www.w3.org/2000/svg'>
       <path
@@ -9287,8 +9287,12 @@ export function NetSuiteIcon(props: SVGProps<SVGSVGElement>) {
   )
 }
 
+export function NetSuiteIcon(props: SVGProps<SVGSVGElement>) {
+  return <OracleOvalMark {...props} />
+}
+
 export function OracleDatabaseIcon(props: SVGProps<SVGSVGElement>) {
-  return <NetSuiteIcon {...props} />
+  return <OracleOvalMark {...props} />
 }
 
 export function WizaIcon(props: SVGProps<SVGSVGElement>) {

apps/sim/app/(landing)/integrations/(shell)/[slug]/page.tsx

@@ -110,7 +110,7 @@ const AUTH_STEP: Record<AuthType, (name: string) => string> = {
     `Connect your ${name} account with one-click OAuth, with no credentials to copy.`,
   'api-key': (name) =>
     `Paste your ${name} API key to authenticate. You can find it in your ${name} account settings.`,
-  none: () => 'No authentication is needed, so the block works as soon as you drop it in.',
+  none: () => 'Configure the block directly; no separate account connection is needed.',
 }
 
 /** Human-readable catalog refresh date for the visible last-updated line. */
@@ -503,7 +503,7 @@ export default async function IntegrationPage({ params }: { params: Promise<{ sl
             ? `${name} connects with one-click OAuth.`
             : authType === 'api-key'
               ? `${name} connects with an API key.`
-              : `${name} requires no authentication.`}{' '}
+              : `${name} is configured directly in its workflow block.`}{' '}
           Free to start at sim.ai.
         </p>
 
@@ -658,7 +658,7 @@ export default async function IntegrationPage({ params }: { params: Promise<{ sl
                     ? `Open your workspace, drag ${articleFor(name)} ${name} block onto the workflow builder, and connect your account with one-click OAuth.`
                     : authType === 'api-key'
                       ? `Open your workspace, drag ${articleFor(name)} ${name} block onto the workflow builder, and paste in your ${name} API key.`
-                      : `Open your workspace, drag ${articleFor(name)} ${name} block onto the workflow builder. No authentication is needed.`,
+                      : `Open your workspace, drag ${articleFor(name)} ${name} block onto the workflow builder, and configure its inputs directly. No separate account connection is needed.`,
               },
               {
                 step: '03',

apps/sim/components/icons.tsx

@@ -9276,7 +9276,7 @@ export function NewRelicIcon(props: SVGProps<SVGSVGElement>) {
   )
 }
 
-export function NetSuiteIcon(props: SVGProps<SVGSVGElement>) {
+function OracleOvalMark(props: SVGProps<SVGSVGElement>) {
   return (
     <svg {...props} viewBox='0 0 93.9 59.4' xmlns='http://www.w3.org/2000/svg'>
       <path
@@ -9287,8 +9287,12 @@ export function NetSuiteIcon(props: SVGProps<SVGSVGElement>) {
   )
 }
 
+export function NetSuiteIcon(props: SVGProps<SVGSVGElement>) {
+  return <OracleOvalMark {...props} />
+}
+
 export function OracleDatabaseIcon(props: SVGProps<SVGSVGElement>) {
-  return <NetSuiteIcon {...props} />
+  return <OracleOvalMark {...props} />
 }
 
 export function WizaIcon(props: SVGProps<SVGSVGElement>) {

apps/sim/lib/internal/oracledb/public-contract.test.ts

@@ -11,6 +11,7 @@ import {
   oracleQueryTool,
   oracleUpdateTool,
 } from '@/tools/oracledb'
+import type { OracleQueryParams } from '@/tools/oracledb/types'
 
 const CONNECTION_FIELDS = [
   'host',
@@ -115,6 +116,23 @@ describe('Oracle Database public integration contract', () => {
     })
   })
 
+  it('accepts the defaulted connection fields as optional in the exported contract', () => {
+    const minimal = {
+      host: 'db.example.com',
+      serviceName: 'FREEPDB1',
+      username: 'application',
+      password: 'secret',
+      query: 'SELECT 1 FROM DUAL',
+    } satisfies OracleQueryParams
+
+    expect(oracleQueryTool.operation.input(minimal)).toMatchObject({
+      port: 1521,
+      protocol: 'tcp',
+      connectionType: 'serviceName',
+      connectionTimeout: 15000,
+    })
+  })
+
   it('selects exactly one service identifier and only forwards wallets for TCPS', () => {
     const service = buildParams({
       ...connection,

apps/sim/lib/internal/oracledb/query.test.ts

@@ -129,9 +129,27 @@ describe('Oracle SQL validation and builders', () => {
     ).toThrow('always-true')
   })
 
-  it('accepts ordinary function, range, and q-quoted predicates', () => {
+  it('rejects unbound placeholders in structured WHERE clauses', () => {
+    expect(() => buildOracleUpdate(undefined, 'Users', { active: 0 }, 'id = :b1')).toThrow(
+      'bind placeholders'
+    )
+    expect(() => buildOracleDelete(undefined, 'Users', 'id = :id')).toThrow('bind placeholders')
+  })
+
+  it('accepts ordinary function, range, quoted-colon, and q-quoted predicates', () => {
     expect(() =>
-      buildOracleDelete(undefined, 'Users', "UPPER(name) = UPPER(q'[Ada]') AND id BETWEEN 1 AND 10")
+      buildOracleDelete(
+        undefined,
+        'Users',
+        "UPPER(name) = UPPER(q'[Ada]') AND note = 'a:b' AND id BETWEEN 1 AND 10"
+      )
+    ).not.toThrow()
+    expect(() =>
+      buildOracleDelete(
+        undefined,
+        'Users',
+        `JSON_OBJECT('id':(id) RETURNING VARCHAR2) = '{"id":42}'`
+      )
     ).not.toThrow()
   })
 })

apps/sim/lib/internal/oracledb/query.ts

@@ -328,6 +328,13 @@ export function validateOracleWhere(where: string): ValidationResult {
   if (scan.error) return invalid(scan.error)
   if (scan.hasComment) return invalid('WHERE clause cannot contain SQL comments or hints')
   if (scan.semicolonIndex !== undefined) return invalid('WHERE clause cannot contain a semicolon')
+  // Oracle also uses `:` in JSON_OBJECT; a parenthesized value is the documented
+  // form that keeps client drivers from interpreting the separator as a bind.
+  if (/:(?!\s*\()/.test(scan.masked)) {
+    return invalid(
+      'Structured WHERE clauses cannot contain bind placeholders; use literal predicates or Execute with named binds'
+    )
+  }
   if (ORACLE_WHERE_MASKED_PATTERNS.some((pattern) => pattern.test(scan.masked))) {
     return invalid('WHERE clause contains a disallowed or always-true expression')
   }

apps/sim/package.json

@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "engines": {
     "bun": ">=1.3.14",
-    "node": ">=22.19.0"
+    "node": ">=24.0.0 <25.0.0"
   },
   "scripts": {
     "dev": "bun run dev:cache:cap && next dev --port 3000",

apps/sim/tools/oracledb/types.ts

@@ -8,9 +8,9 @@ export type OracleBinds = Record<string, OracleBindScalar>
 /** Connection fields accepted by every Oracle Database tool. */
 export interface OracleConnectionConfig {
   host: string
-  port: number
-  protocol: OracleProtocol
-  connectionType: OracleConnectionType
+  port?: number
+  protocol?: OracleProtocol
+  connectionType?: OracleConnectionType
   serviceName?: string
   sid?: string
   username: string