fix(mothership): lint (#3517)

* fix(mothership): lint

* fix typing

Author: icecrasher321

apps/sim/app/api/schedules/[id]/route.ts

@@ -75,6 +75,11 @@ async function fetchAndAuthorize(
     return { schedule, workspaceId: schedule.sourceWorkspaceId }
   }
 
+  if (!schedule.workflowId) {
+    logger.warn(`[${requestId}] Schedule has no workflow: ${scheduleId}`)
+    return NextResponse.json({ error: 'Schedule has no associated workflow' }, { status: 400 })
+  }
+
   const authorization = await authorizeWorkflowByWorkspacePermission({
     workflowId: schedule.workflowId,
     userId,

apps/sim/app/api/schedules/execute/route.ts

@@ -93,7 +93,7 @@ export async function GET(request: NextRequest) {
 
       try {
         const jobId = await jobQueue.enqueue('schedule-execution', payload, {
-          metadata: { workflowId: schedule.workflowId },
+          metadata: { workflowId: schedule.workflowId ?? undefined },
         })
         logger.info(
           `[${requestId}] Queued schedule execution task ${jobId} for workflow ${schedule.workflowId}`

apps/sim/app/api/table/utils.ts

@@ -155,7 +155,9 @@ export function serverErrorResponse(message = 'Internal server error') {
   return errorResponse(message, 500)
 }
 
-const columnTypeEnum = z.enum(COLUMN_TYPES as unknown as [string, ...string[]])
+const columnTypeEnum = z.enum(
+  COLUMN_TYPES as unknown as [(typeof COLUMN_TYPES)[number], ...(typeof COLUMN_TYPES)[number][]]
+)
 
 export const CreateColumnSchema = z.object({
   workspaceId: z.string().min(1, 'Workspace ID is required'),

apps/sim/app/api/v1/knowledge/[id]/documents/[documentId]/route.ts

@@ -1,5 +1,5 @@
 import { db } from '@sim/db'
-import { document } from '@sim/db/schema'
+import { document, knowledgeConnector } from '@sim/db/schema'
 import { and, eq, isNull } from 'drizzle-orm'
 import { type NextRequest, NextResponse } from 'next/server'
 import { z } from 'zod'
@@ -64,10 +64,11 @@ export async function GET(request: NextRequest, { params }: DocumentDetailRouteP
         enabled: document.enabled,
         uploadedAt: document.uploadedAt,
         connectorId: document.connectorId,
-        connectorType: document.connectorType,
+        connectorType: knowledgeConnector.connectorType,
         sourceUrl: document.sourceUrl,
       })
       .from(document)
+      .leftJoin(knowledgeConnector, eq(document.connectorId, knowledgeConnector.id))
       .where(
         and(
           eq(document.id, documentId),

apps/sim/app/api/v1/knowledge/route.ts

@@ -93,7 +93,7 @@ export async function POST(request: NextRequest) {
         userId,
         embeddingModel: 'text-embedding-3-small',
         embeddingDimension: 1536,
-        chunkingConfig,
+        chunkingConfig: chunkingConfig ?? { maxSize: 1024, minSize: 100, overlap: 200 },
       },
       requestId
     )

apps/sim/app/api/v1/knowledge/search/route.ts

@@ -240,7 +240,7 @@ export async function POST(request: NextRequest) {
           const tags: Record<string, string | number | boolean | Date | null> = {}
 
           ALL_TAG_SLOTS.forEach((slot) => {
-            const tagValue = (result as Record<string, unknown>)[slot]
+            const tagValue = result[slot as keyof SearchResult]
             if (tagValue !== null && tagValue !== undefined) {
               const displayName = kbTagMap[slot] || slot
               tags[displayName] = tagValue as string | number | boolean | Date | null

apps/sim/app/api/v1/knowledge/utils.ts

@@ -91,10 +91,10 @@ export async function resolveKnowledgeBase(
 /**
  * Validates data against a Zod schema with consistent error response.
  */
-export function validateSchema<T>(
-  schema: z.ZodSchema<T>,
+export function validateSchema<S extends z.ZodType>(
+  schema: S,
   data: unknown
-): { success: true; data: T } | { success: false; response: NextResponse } {
+): { success: true; data: z.output<S> } | { success: false; response: NextResponse } {
   const result = schema.safeParse(data)
   if (!result.success) {
     return {

apps/sim/app/chat/components/input/input.tsx

@@ -44,8 +44,11 @@ export const ChatInput: React.FC<{
   const isDragOver = dragCounter > 0
 
   // Check if speech-to-text is available in the browser
-  const isSttAvailable =
-    typeof window !== 'undefined' && !!(window.SpeechRecognition || window.webkitSpeechRecognition)
+  const isSttAvailable = (() => {
+    if (typeof window === 'undefined') return false
+    const w = window as Window & { SpeechRecognition?: unknown; webkitSpeechRecognition?: unknown }
+    return !!(w.SpeechRecognition || w.webkitSpeechRecognition)
+  })()
 
   // Function to adjust textarea height
   const adjustTextareaHeight = () => {

apps/sim/app/chat/components/input/voice-input.tsx

@@ -31,11 +31,9 @@ interface SpeechRecognitionStatic {
   new (): SpeechRecognition
 }
 
-declare global {
-  interface Window {
-    SpeechRecognition?: SpeechRecognitionStatic
-    webkitSpeechRecognition?: SpeechRecognitionStatic
-  }
+type WindowWithSpeech = Window & {
+  SpeechRecognition?: SpeechRecognitionStatic
+  webkitSpeechRecognition?: SpeechRecognitionStatic
 }
 
 interface VoiceInputProps {
@@ -57,8 +55,9 @@ export function VoiceInput({
 
   // Check if speech recognition is supported
   useEffect(() => {
-    const SpeechRecognition = window.SpeechRecognition || window.webkitSpeechRecognition
-    setIsSupported(!!SpeechRecognition)
+    const w = window as WindowWithSpeech
+    const SpeechRecognitionCtor = w.SpeechRecognition || w.webkitSpeechRecognition
+    setIsSupported(!!SpeechRecognitionCtor)
   }, [])
 
   const handleVoiceClick = useCallback(() => {

apps/sim/app/chat/components/voice-interface/voice-interface.tsx

@@ -36,11 +36,9 @@ interface SpeechRecognitionStatic {
   new (): SpeechRecognition
 }
 
-declare global {
-  interface Window {
-    SpeechRecognition?: SpeechRecognitionStatic
-    webkitSpeechRecognition?: SpeechRecognitionStatic
-  }
+type WindowWithSpeech = Window & {
+  SpeechRecognition?: SpeechRecognitionStatic
+  webkitSpeechRecognition?: SpeechRecognitionStatic
 }
 
 interface VoiceInterfaceProps {
@@ -93,7 +91,11 @@ export function VoiceInterface({
   const responseTimeoutRef = useRef<NodeJS.Timeout | null>(null)
 
   const isSupported =
-    typeof window !== 'undefined' && !!(window.SpeechRecognition || window.webkitSpeechRecognition)
+    typeof window !== 'undefined' &&
+    !!(
+      (window as WindowWithSpeech).SpeechRecognition ||
+      (window as WindowWithSpeech).webkitSpeechRecognition
+    )
 
   useEffect(() => {
     isMutedRef.current = isMuted
@@ -214,7 +216,8 @@ export function VoiceInterface({
   const setupSpeechRecognition = useCallback(() => {
     if (!isSupported) return
 
-    const SpeechRecognition = window.SpeechRecognition || window.webkitSpeechRecognition
+    const w = window as WindowWithSpeech
+    const SpeechRecognition = w.SpeechRecognition || w.webkitSpeechRecognition
     if (!SpeechRecognition) return
 
     const recognition = new SpeechRecognition()