Commit 546aac6
fix: address the first review round on the combined PR
The mirror override in the inventory header double-prefixed. It told operators
to override the device plugin with `<your-registry>/nvidia/k8s-device-plugin`
while global rewriting stayed on, so `sim.image` prepended the registry a second
time and the DaemonSet landed in ImagePullBackOff. Verified by rendering both
forms; the override has to be the bare repository. The plugin's DaemonSet also
now carries `global.imagePullSecrets`, which it was the only workload to omit —
an authenticated mirror could not pull it.
The resolver skipped `latest*` whenever the alias did not resolve to this run's
index, which conflated "the guard withheld it" with "the read was stale".
create-ghcr-manifests now publishes its guard decision and the resolver fails
instead of skipping when the guard says latest was published this run.
Docs corrections, each verified against source:
- The loopback carve-out does lift plain HTTP and the private-address block; it
leaves only the denied-port list in force. `egress.ts` skips the port check
for allowlist vouching alone, which is what makes `http://localhost:5432`
stay refused.
- Not every guarded response is capped — the pinned fetch used by provider SDKs
sets no limit.
- A partially configured storage backend is skipped when a later one is
complete; it fails only when none is.
- GCE Ingress can serve a provisioned TLS Secret, so cert-manager is an
alternative to a ManagedCertificate rather than requiring a different
controller.
- Workload Identity needs roles/iam.serviceAccountTokenCreator to sign GCS URLs.
- NEXT_PUBLIC_BRAND_BACKGROUND_COLOR is a contrast flag, not a background.
- NEXT_PUBLIC_SANDBOXES_ENABLED is a browser gate, not provider readiness.
- An incomplete certificate chain is not fixed by NODE_EXTRA_CA_CERTS; the
endpoint has to serve the intermediate.
- Script migrations run once — the eight retries are for SQL lock timeouts.
- NO_PROXY belongs in the application environment, not a shell assignment, and
the GKE annotate command no longer hard-codes a release name and namespace.
- Pi's own image, the Microsoft login callback, the custom-block identity split,
the whitelabeling surfaces that ignore configured URLs, and sim-setup's
Compose-only scope are all now stated.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015BwsJTEQRzWJaY4BRCkPZt1 parent 01c4e12 commit 546aac6
22 files changed
Lines changed: 69 additions & 35 deletions
File tree
- .github/workflows
- apps/docs/content/docs/platform
- enterprise
- self-hosting
- helm/sim
- templates
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
554 | 554 | | |
555 | 555 | | |
556 | 556 | | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
557 | 562 | | |
558 | 563 | | |
559 | 564 | | |
| |||
661 | 666 | | |
662 | 667 | | |
663 | 668 | | |
| 669 | + | |
664 | 670 | | |
665 | 671 | | |
666 | 672 | | |
| |||
759 | 765 | | |
760 | 766 | | |
761 | 767 | | |
762 | | - | |
763 | | - | |
764 | | - | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
765 | 772 | | |
766 | | - | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
767 | 778 | | |
768 | 779 | | |
769 | 780 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
| 216 | + | |
| 217 | + | |
217 | 218 | | |
218 | 219 | | |
219 | 220 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
| 147 | + | |
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
| 170 | + | |
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| 146 | + | |
146 | 147 | | |
147 | 148 | | |
148 | 149 | | |
| |||
0 commit comments