Skip to content

Commit 3c373a0

Browse files
waleedlatif1claude
andcommitted
fix(rootly): remove non-TSDoc comments, add empty body to acknowledge_alert
Remove all inline section comments from block definition per CLAUDE.md guidelines. Add explicit empty JSON:API body to acknowledge_alert POST to prevent potential 400 from servers expecting a body with Content-Type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 847e00b commit 3c373a0

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

apps/sim/blocks/blocks/rootly.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
5353
value: () => 'rootly_create_incident',
5454
},
5555

56-
// Create Incident fields
5756
{
5857
id: 'title',
5958
title: 'Title',
@@ -183,7 +182,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
183182
mode: 'advanced',
184183
},
185184

186-
// Get Incident fields
187185
{
188186
id: 'getIncidentId',
189187
title: 'Incident ID',
@@ -193,7 +191,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
193191
required: { field: 'operation', value: 'rootly_get_incident' },
194192
},
195193

196-
// Update Incident fields
197194
{
198195
id: 'updateIncidentId',
199196
title: 'Incident ID',
@@ -354,7 +351,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
354351
mode: 'advanced',
355352
},
356353

357-
// List Incidents fields
358354
{
359355
id: 'listIncidentsStatus',
360356
title: 'Status Filter',
@@ -447,7 +443,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
447443
mode: 'advanced',
448444
},
449445

450-
// Create Alert fields
451446
{
452447
id: 'alertSummary',
453448
title: 'Summary',
@@ -533,7 +528,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
533528
mode: 'advanced',
534529
},
535530

536-
// List Alerts fields
537531
{
538532
id: 'listAlertsStatus',
539533
title: 'Status Filter',
@@ -598,7 +592,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
598592
mode: 'advanced',
599593
},
600594

601-
// Add Incident Event fields
602595
{
603596
id: 'eventIncidentId',
604597
title: 'Incident ID',
@@ -629,7 +622,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
629622
mode: 'advanced',
630623
},
631624

632-
// List Services fields
633625
{
634626
id: 'servicesSearch',
635627
title: 'Search',
@@ -654,7 +646,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
654646
mode: 'advanced',
655647
},
656648

657-
// List Severities fields
658649
{
659650
id: 'severitiesSearch',
660651
title: 'Search',
@@ -679,7 +670,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
679670
mode: 'advanced',
680671
},
681672

682-
// List Teams fields
683673
{
684674
id: 'teamsSearch',
685675
title: 'Search',
@@ -704,7 +694,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
704694
mode: 'advanced',
705695
},
706696

707-
// List Environments fields
708697
{
709698
id: 'environmentsSearch',
710699
title: 'Search',
@@ -729,7 +718,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
729718
mode: 'advanced',
730719
},
731720

732-
// List Incident Types fields
733721
{
734722
id: 'incidentTypesSearch',
735723
title: 'Name Filter',
@@ -754,7 +742,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
754742
mode: 'advanced',
755743
},
756744

757-
// List Functionalities fields
758745
{
759746
id: 'functionalitiesSearch',
760747
title: 'Search',
@@ -779,7 +766,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
779766
mode: 'advanced',
780767
},
781768

782-
// List Retrospectives fields
783769
{
784770
id: 'retrospectivesStatus',
785771
title: 'Status Filter',
@@ -816,7 +802,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
816802
mode: 'advanced',
817803
},
818804

819-
// Delete Incident fields
820805
{
821806
id: 'deleteIncidentId',
822807
title: 'Incident ID',
@@ -826,7 +811,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
826811
required: { field: 'operation', value: 'rootly_delete_incident' },
827812
},
828813

829-
// Get Alert fields
830814
{
831815
id: 'getAlertId',
832816
title: 'Alert ID',
@@ -836,7 +820,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
836820
required: { field: 'operation', value: 'rootly_get_alert' },
837821
},
838822

839-
// Update Alert fields
840823
{
841824
id: 'updateAlertId',
842825
title: 'Alert ID',
@@ -916,7 +899,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
916899
mode: 'advanced',
917900
},
918901

919-
// Acknowledge Alert fields
920902
{
921903
id: 'ackAlertId',
922904
title: 'Alert ID',
@@ -926,7 +908,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
926908
required: { field: 'operation', value: 'rootly_acknowledge_alert' },
927909
},
928910

929-
// Resolve Alert fields
930911
{
931912
id: 'resolveAlertId',
932913
title: 'Alert ID',
@@ -955,7 +936,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
955936
mode: 'advanced',
956937
},
957938

958-
// Create Action Item fields
959939
{
960940
id: 'actionItemIncidentId',
961941
title: 'Incident ID',
@@ -1043,7 +1023,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
10431023
},
10441024
},
10451025

1046-
// List Action Items fields
10471026
{
10481027
id: 'listActionItemsIncidentId',
10491028
title: 'Incident ID',
@@ -1069,7 +1048,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
10691048
mode: 'advanced',
10701049
},
10711050

1072-
// List Users fields
10731051
{
10741052
id: 'usersSearch',
10751053
title: 'Search',
@@ -1102,7 +1080,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
11021080
mode: 'advanced',
11031081
},
11041082

1105-
// List On-Calls fields
11061083
{
11071084
id: 'onCallsScheduleIds',
11081085
title: 'Schedule IDs',
@@ -1134,7 +1111,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
11341111
mode: 'advanced',
11351112
},
11361113

1137-
// List Schedules fields
11381114
{
11391115
id: 'schedulesSearch',
11401116
title: 'Search',
@@ -1159,7 +1135,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
11591135
mode: 'advanced',
11601136
},
11611137

1162-
// List Escalation Policies fields
11631138
{
11641139
id: 'escalationPoliciesSearch',
11651140
title: 'Search',
@@ -1184,7 +1159,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
11841159
mode: 'advanced',
11851160
},
11861161

1187-
// List Causes fields
11881162
{
11891163
id: 'causesSearch',
11901164
title: 'Search',
@@ -1209,7 +1183,6 @@ export const RootlyBlock: BlockConfig<RootlyResponse> = {
12091183
mode: 'advanced',
12101184
},
12111185

1212-
// List Playbooks fields
12131186
{
12141187
id: 'playbooksPageSize',
12151188
title: 'Page Size',

apps/sim/tools/rootly/acknowledge_alert.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export const rootlyAcknowledgeAlertTool: ToolConfig<
3535
'Content-Type': 'application/vnd.api+json',
3636
Authorization: `Bearer ${params.apiKey}`,
3737
}),
38+
body: () => ({ data: {} }),
3839
},
3940

4041
transformResponse: async (response: Response) => {

0 commit comments

Comments
 (0)