fix(workflows): enforce undeploy rollback failures

Author: PlaneInABottle

apps/sim/app/api/workflows/[id]/deploy/route.test.ts

@@ -417,6 +417,71 @@ describe('Workflow deploy route', () => {
     })
   })
 
+  it('fails first deploy rollback when undeploy reports failure before deletion', async () => {
+    mockValidateWorkflowAccess.mockResolvedValue({
+      workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },
+      auth: {
+        success: true,
+        userId: 'api-user',
+        userName: 'API Key Actor',
+        userEmail: 'api@example.com',
+        authType: 'api_key',
+      },
+    })
+    mockDeployWorkflow.mockResolvedValue({
+      success: true,
+      deployedAt: '2024-02-01T00:00:00Z',
+      deploymentVersionId: 'dep-failed',
+    })
+    mockSaveTriggerWebhooksForDeploy.mockResolvedValue({
+      success: false,
+      error: { message: 'Failed to save trigger configuration', status: 500 },
+    })
+    mockDbLimit.mockResolvedValue([])
+    mockUndeployWorkflow.mockResolvedValue({ success: false, error: 'undeploy failed' })
+
+    const req = new NextRequest('http://localhost:3000/api/workflows/wf-1/deploy', {
+      method: 'POST',
+      headers: { 'x-api-key': 'test-key' },
+    })
+    const response = await POST(req, { params: Promise.resolve({ id: 'wf-1' }) })
+
+    expect(response.status).toBe(500)
+    expect(await response.json()).toEqual({ error: 'undeploy failed', code: 'UNDEPLOY_FAILED' })
+    expect(mockUndeployWorkflow).toHaveBeenCalledWith({ workflowId: 'wf-1' })
+    expect(mockDeleteDeploymentVersionById).not.toHaveBeenCalled()
+  })
+
+  it('fails when deployment version id is missing and undeploy reports failure', async () => {
+    mockValidateWorkflowAccess.mockResolvedValue({
+      workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },
+      auth: {
+        success: true,
+        userId: 'api-user',
+        userName: 'API Key Actor',
+        userEmail: 'api@example.com',
+        authType: 'api_key',
+      },
+    })
+    mockDeployWorkflow.mockResolvedValue({
+      success: true,
+      deployedAt: '2024-02-01T00:00:00Z',
+      deploymentVersionId: undefined,
+    })
+    mockUndeployWorkflow.mockResolvedValue({ success: false, error: 'undeploy failed' })
+
+    const req = new NextRequest('http://localhost:3000/api/workflows/wf-1/deploy', {
+      method: 'POST',
+      headers: { 'x-api-key': 'test-key' },
+    })
+    const response = await POST(req, { params: Promise.resolve({ id: 'wf-1' }) })
+
+    expect(response.status).toBe(500)
+    expect(await response.json()).toEqual({ error: 'undeploy failed', code: 'UNDEPLOY_FAILED' })
+    expect(mockUndeployWorkflow).toHaveBeenCalledWith({ workflowId: 'wf-1' })
+    expect(mockDeleteDeploymentVersionById).not.toHaveBeenCalled()
+  })
+
   it('allows API-key auth for undeploy using hybrid auth userId', async () => {
     mockValidateWorkflowAccess.mockResolvedValue({
       workflow: { id: 'wf-1', name: 'Test Workflow', workspaceId: 'ws-1' },

apps/sim/app/api/workflows/[id]/deploy/route.ts

@@ -170,7 +170,15 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
         }
       }
 
-      await undeployWorkflow({ workflowId: id })
+      const undeployResult = await undeployWorkflow({ workflowId: id })
+      if (!undeployResult.success) {
+        return createErrorResponse(
+          undeployResult.error || 'Failed to undeploy workflow',
+          500,
+          'UNDEPLOY_FAILED'
+        )
+      }
+
       await ensureFailedDeploymentVersionDeleted()
     }
 
@@ -188,7 +196,15 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
     const deploymentVersionId = deployResult.deploymentVersionId
 
     if (!deploymentVersionId) {
-      await undeployWorkflow({ workflowId: id })
+      const undeployResult = await undeployWorkflow({ workflowId: id })
+      if (!undeployResult.success) {
+        return createErrorResponse(
+          undeployResult.error || 'Failed to undeploy workflow',
+          500,
+          'UNDEPLOY_FAILED'
+        )
+      }
+
       return createErrorResponse('Failed to resolve deployment version', 500)
     }
 
@@ -210,7 +226,10 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
         requestId,
         deploymentVersionId,
       })
-      await rollbackDeployment(deploymentVersionId)
+      const rollbackResponse = await rollbackDeployment(deploymentVersionId)
+      if (rollbackResponse) {
+        return rollbackResponse
+      }
       return createErrorResponse(
         triggerSaveResult.error?.message || 'Failed to save trigger configuration',
         triggerSaveResult.error?.status || 500
@@ -234,7 +253,10 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
         requestId,
         deploymentVersionId,
       })
-      await rollbackDeployment(deploymentVersionId)
+      const rollbackResponse = await rollbackDeployment(deploymentVersionId)
+      if (rollbackResponse) {
+        return rollbackResponse
+      }
       return createErrorResponse(scheduleResult.error || 'Failed to create schedule', 500)
     }
     if (scheduleResult.scheduleId) {