RFC compliance and fixes for issue #137 #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC compliance and fixes for issue simshaun#137
Fix failing Codeclimate checks
Codeclimate not happy part 2
ftcvlad
changed the title
ftcvlad
changed the title
ftcvlad
changed the title
ftcvlad
changed the title
|
This looks quite useful. |
|
@simshaun Hi, could you please make a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #137 (bugs 1 and 3). 'DTEND not predictable' mentioned in #137 happens because DTEND from rrule string takes precedence over the one set by parameter. This is not changed.
Bug 1: recurr does not parse rrule string correctly if the string has TZID. At the same time when converting Rule to string recurr is able to output TZID.
Bug 2: When converting Rule to string, recurr outputs 'DTSTART=', which RFC 5545 doesnt allow, and which recurr is not able to correctly parse
Bug 3: If endDate is passed as DateTimeImmutable it is not applied to the produced rrule string because the check is
instanceOf DateTime. Check forDateTimeInterfaceDTSTART, DTEND and TZID from rrule string take precedence over constructor parameters