From 82b9bcdc3162b63988159993b57595e805969a99 Mon Sep 17 00:00:00 2001
From: Brecht Billiet <brechtbilliet@Brechts-MacBook-Pro.local>
Date: Fri, 19 Apr 2024 11:26:31 +0200
Subject: [PATCH] fix(connect): fix issue with connect effect

connect should act on each key independently
---
 .../ngx-signal-state/src/lib/signal-state.ts     | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/projects/ngx-signal-state/src/lib/signal-state.ts b/projects/ngx-signal-state/src/lib/signal-state.ts
index 97d5de9..b0827aa 100644
--- a/projects/ngx-signal-state/src/lib/signal-state.ts
+++ b/projects/ngx-signal-state/src/lib/signal-state.ts
@@ -111,16 +111,16 @@ export class SignalState<T extends Record<string, unknown>> {
    */
   public connect(partial: Partial<{ [P in keyof T]: Signal<T[P]> }>): void {
     this.throwOrReturnSignals();
-    effect(
-      () => {
-        Object.keys(partial).forEach((key: keyof T) => {
+    Object.keys(partial).forEach((key: keyof T) => {
+      effect(
+        () => {
           const v = partial[key] as Signal<keyof T>;
           this.patch({ [key]: v() } as Partial<T>);
-        });
-      },
-      // This will update the state, so we need to allow signal writes
-      { allowSignalWrites: true }
-    );
+        },
+        // This will update the state, so we need to allow signal writes
+        { allowSignalWrites: true }
+      );
+    });
   }
 
   /**