Replace super-linter with a reusable workflow #90
php.yml
on: pull_request
Linter
/
ecmascript-linter
Linter
/
json-linter
Linter
/
style-linter
Linter
/
yaml-linter
Matrix: PHP-Linter
Matrix: unit-tests-windows
Matrix: unit-tests-linux
Cleanup artifacts
0s
Annotations
13 errors and 3 warnings
|
Quality control
Process completed with exit code 2.
|
|
MissingOverrideAttribute:
tests/src/Controller/DebugTest.php#L34
tests/src/Controller/DebugTest.php:34:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\saml2debug\Controller\DebugTest::setup should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedClass:
tests/src/Controller/DebugTest.php#L20
tests/src/Controller/DebugTest.php:20:13: UnusedClass: Class SimpleSAML\Test\Module\saml2debug\Controller\DebugTest is never used (see https://psalm.dev/075)
|
|
Quality control
Process completed with exit code 2.
|
|
PossiblyFalseArgument:
src/Controller/Debug.php#L167
src/Controller/Debug.php:167:44: PossiblyFalseArgument: Argument 1 of base64_encode cannot be false, possibly string value expected (see https://psalm.dev/104)
|
|
RiskyTruthyFalsyComparison:
src/Controller/Debug.php#L117
src/Controller/Debug.php:117:14: RiskyTruthyFalsyComparison: Operand of type false|null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
|
PossiblyNullArgument:
src/Controller/Debug.php#L97
src/Controller/Debug.php:97:51: PossiblyNullArgument: Argument 1 of SimpleSAML\Module\saml2debug\Controller\Debug::parseDecodedMessage cannot be null, possibly null value provided (see https://psalm.dev/078)
|
|
ArgumentTypeCoercion:
src/Controller/Debug.php#L97
src/Controller/Debug.php:97:51: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Module\saml2debug\Controller\Debug::parseDecodedMessage expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
|
PossiblyNullArgument:
src/Controller/Debug.php#L67
src/Controller/Debug.php:67:17: PossiblyNullArgument: Argument 2 of SimpleSAML\Module\saml2debug\Controller\Debug::parseEncodedMessage cannot be null, possibly null value provided (see https://psalm.dev/078)
|
|
ArgumentTypeCoercion:
src/Controller/Debug.php#L67
src/Controller/Debug.php:67:17: ArgumentTypeCoercion: Argument 2 of SimpleSAML\Module\saml2debug\Controller\Debug::parseEncodedMessage expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
|
PossiblyNullArgument:
src/Controller/Debug.php#L66
src/Controller/Debug.php:66:17: PossiblyNullArgument: Argument 1 of SimpleSAML\Module\saml2debug\Controller\Debug::parseEncodedMessage cannot be null, possibly null value provided (see https://psalm.dev/078)
|
|
ArgumentTypeCoercion:
src/Controller/Debug.php#L66
src/Controller/Debug.php:66:17: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Module\saml2debug\Controller\Debug::parseEncodedMessage expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
|
ClassMustBeFinal:
src/Controller/Debug.php#L20
src/Controller/Debug.php:20:7: ClassMustBeFinal: Class SimpleSAML\Module\saml2debug\Controller\Debug is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/DebugTest.php#L26
tests/src/Controller/DebugTest.php:26:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\saml2debug\Controller\DebugTest::$session is not defined in constructor of SimpleSAML\Test\Module\saml2debug\Controller\DebugTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/DebugTest.php#L23
tests/src/Controller/DebugTest.php:23:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\saml2debug\Controller\DebugTest::$config is not defined in constructor of SimpleSAML\Test\Module\saml2debug\Controller\DebugTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
UnusedClass:
src/Controller/Debug.php#L20
src/Controller/Debug.php:20:7: UnusedClass: Class SimpleSAML\Module\saml2debug\Controller\Debug is never used (see https://psalm.dev/075)
|