Skip to content

Fix sniffer-issues #143

Fix sniffer-issues

Fix sniffer-issues #143

Triggered via push April 24, 2025 14:42
Status Failure
Total duration 2m 34s
Artifacts

php.yml

on: push
Matrix: PHP-Linter
Linter  /  ecmascript-linter
Linter / ecmascript-linter
Linter  /  json-linter
Linter / json-linter
Linter  /  style-linter
Linter / style-linter
Linter  /  yaml-linter
Linter / yaml-linter
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
11s
Code coverage
Quality control
35s
Quality control
Security checks
22s
Security checks
Cleanup artifacts
3s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 13 warnings
Quality control
Process completed with exit code 2.
UnusedIssueHandlerSuppression: psalm-dev.xml#L0
/home/runner/work/simplesamlphp-module-negotiateext/simplesamlphp-module-negotiateext/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
UnnecessaryVarAnnotation: tests/src/Controller/NegotiateControllerTest.php#L161
tests/src/Controller/NegotiateControllerTest.php:161:18: UnnecessaryVarAnnotation: The @var SimpleSAML\XHTML\Template annotation for $response is unnecessary (see https://psalm.dev/212)
UnnecessaryVarAnnotation: tests/src/Controller/NegotiateControllerTest.php#L129
tests/src/Controller/NegotiateControllerTest.php:129:18: UnnecessaryVarAnnotation: The @var SimpleSAML\XHTML\Template annotation for $response is unnecessary (see https://psalm.dev/212)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L32
tests/src/Controller/NegotiateControllerTest.php:32:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest::setup should have the "Override" attribute (see https://psalm.dev/358)
UnusedClass: tests/src/Controller/NegotiateControllerTest.php#L21
tests/src/Controller/NegotiateControllerTest.php:21:7: UnusedClass: Class SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest is never used (see https://psalm.dev/075)
RiskyTruthyFalsyComparison: src/Auth/Source/Negotiate.php#L230
src/Auth/Source/Negotiate.php:230:13: RiskyTruthyFalsyComparison: Operand of type array<array-key, mixed>|null contains type array<array-key, mixed>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
PossiblyNullArgument: src/Auth/Source/Negotiate.php#L229
src/Auth/Source/Negotiate.php:229:41: PossiblyNullArgument: Argument 1 of SimpleSAML\Module\negotiateext\Auth\Source\Negotiate::lookupUserData cannot be null, possibly null value provided (see https://psalm.dev/078)
PossiblyUndefinedArrayOffset: src/Auth/Source/Negotiate.php#L227
src/Auth/Source/Negotiate.php:227:17: PossiblyUndefinedArrayOffset: Possibly undefined array key $_SERVER['REMOTE_USER'] on array{APP_DEBUG?: bool|string, APP_ENV?: string, AUTH_TYPE?: non-empty-string, CONTENT_LENGTH?: string, CONTENT_TYPE?: string, DOCUMENT_ROOT?: non-empty-string, FCGI_ROLE?: non-empty-string, GATEWAY_INTERFACE?: non-empty-string, HOME?: non-empty-string, HTTPS?: string, HTTP_ACCEPT?: non-empty-string, HTTP_ACCEPT_CHARSET?: non-empty-string, HTTP_ACCEPT_ENCODING?: non-empty-string, HTTP_ACCEPT_LANGUAGE?: non-empty-string, HTTP_CACHE_CONTROL?: non-empty-string, HTTP_CDN_LOOP?: non-empty-string, HTTP_CF_CONNECTING_IP?: non-empty-string, HTTP_CF_IPCOUNTRY?: non-empty-string, HTTP_CF_VISITOR?: non-empty-string, HTTP_CLIENT_IP?: non-empty-string, HTTP_CONNECTION?: non-empty-string, HTTP_COOKIE?: non-empty-string, HTTP_DNT?: non-empty-string, HTTP_HOST?: non-empty-string, HTTP_PRIORITY?: non-empty-string, HTTP_REFERER?: non-empty-string, HTTP_SEC_CH_UA?: non-empty-string, HTTP_SEC_CH_UA_MOBILE?: non-empty-string, HTTP_SEC_CH_UA_PLATFORM?: non-empty-string, HTTP_SEC_FETCH_DEST?: non-empty-string, HTTP_SEC_FETCH_MODE?: non-empty-string, HTTP_SEC_FETCH_SITE?: non-empty-string, HTTP_SEC_FETCH_USER?: non-empty-string, HTTP_UPGRADE_INSECURE_REQUESTS?: non-empty-string, HTTP_USER_AGENT?: non-empty-string, HTTP_X_FORWARDED_FOR?: non-empty-string, HTTP_X_FORWARDED_PROTO?: non-empty-string, HTTP_X_REAL_IP?: non-empty-string, ORIG_PATH_INFO?: non-empty-string, PATH?: non-empty-string, PATH_INFO?: non-empty-string, PATH_TRANSLATED?: non-empty-string, PHP_AUTH_DIGEST?: non-empty-string, PHP_AUTH_PW?: non-empty-string, PHP_AUTH_USER?: non-empty-string, PHP_SELF?: non-empty-string, QUERY_STRING?: string, REDIRECT_REMOTE_USER?: non-empty-string, REDIRECT_STATUS?: non-empty-string, REMOTE_ADDR?: non-empty-string, REMOTE_HOST?: non-empty-string, REMOTE_PORT?: string, REMOTE_USER?: non-empty-string, REQUEST_METHOD?: non-empty-string, REQUEST_SCHEME?: non-empty-string, REQUEST_TIME?: int<1745505875, max>, REQUEST_TIME_FLOAT?: float, REQUEST_URI?: non-empty-string, SCRIPT_FILENAME?: non-empty-string, SCRIPT_NAME?: non-empty-string, SERVER_ADDR?: non-empty-string, SERVER_ADMIN?: non-empty-string, SERVER_NAME?: non-empty-string, SERVER_PORT?: non-empty-string, SERVER_PROTOCOL?: non-empty-string, SERVER_SIGNATURE?: non-empty-string, SERVER_SOFTWARE?: non-empty-string, USER?: non-empty-string, argc?: int<1, max>, argv?: non-empty-list<string>, ...<non-empty-string, string>} (see https://psalm.dev/167)
PossiblyNullArgument: src/Auth/Source/Negotiate.php#L158
src/Auth/Source/Negotiate.php:158:30: PossiblyNullArgument: Argument 1 of Symfony\Component\HttpFoundation\IpUtils::checkIp cannot be null, possibly null value provided (see https://psalm.dev/078)
RiskyTruthyFalsyComparison: src/Auth/Source/Negotiate.php#L93
src/Auth/Source/Negotiate.php:93:15: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
RiskyTruthyFalsyComparison: src/Auth/Source/Negotiate.php#L91
src/Auth/Source/Negotiate.php:91:15: RiskyTruthyFalsyComparison: Operand of type non-empty-array<int|non-empty-string, array<int|non-empty-string, mixed>|string>|null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
MissingOverrideAttribute: src/Auth/Source/Negotiate.php#L70
src/Auth/Source/Negotiate.php:70:5: MissingOverrideAttribute: Method SimpleSAML\Module\negotiateext\Auth\Source\Negotiate::authenticate should have the "Override" attribute (see https://psalm.dev/358)
PossiblyUnusedProperty: src/Auth/Source/Negotiate.php#L34
src/Auth/Source/Negotiate.php:34:22: PossiblyUnusedProperty: Cannot find any references to property SimpleSAML\Module\negotiateext\Auth\Source\Negotiate::$keytab (see https://psalm.dev/149)
MissingClassConstType: src/Auth/Source/Negotiate.php#L25
src/Auth/Source/Negotiate.php:25:18: MissingClassConstType: Class constant "SimpleSAML\Module\negotiateext\Auth\Source\Negotiate::STAGEID" should have a declared type. (see https://psalm.dev/359)
ClassMustBeFinal: src/Auth/Source/Negotiate.php#L22
src/Auth/Source/Negotiate.php:22:7: ClassMustBeFinal: Class SimpleSAML\Module\negotiateext\Auth\Source\Negotiate is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L150
tests/src/Controller/NegotiateControllerTest.php:150:27: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L149
tests/src/Controller/NegotiateControllerTest.php:149:27: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L148
tests/src/Controller/NegotiateControllerTest.php:148:29: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L147
tests/src/Controller/NegotiateControllerTest.php:147:43: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L146
tests/src/Controller/NegotiateControllerTest.php:146:29: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L145
tests/src/Controller/NegotiateControllerTest.php:145:29: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PossiblyUndefinedVariable: tests/src/Controller/NegotiateControllerTest.php#L144
tests/src/Controller/NegotiateControllerTest.php:144:29: PossiblyUndefinedVariable: Possibly undefined variable $cookie, first seen on line 138 (see https://psalm.dev/018)
PropertyNotSetInConstructor: tests/src/Controller/NegotiateControllerTest.php#L27
tests/src/Controller/NegotiateControllerTest.php:27:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest::$session is not defined in constructor of SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: tests/src/Controller/NegotiateControllerTest.php#L24
tests/src/Controller/NegotiateControllerTest.php:24:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest::$config is not defined in constructor of SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest or in any methods called in the constructor (see https://psalm.dev/074)
ClassMustBeFinal: tests/src/Controller/NegotiateControllerTest.php#L21
tests/src/Controller/NegotiateControllerTest.php:21:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\negotiateext\Controller\NegotiateControllerTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
UnusedClass: src/Controller/NegotiateController.php#L27
src/Controller/NegotiateController.php:27:7: UnusedClass: Class SimpleSAML\Module\negotiateext\Controller\NegotiateController is never used (see https://psalm.dev/075)
PossiblyNullOperand: src/Auth/Source/Negotiate.php#L228
src/Auth/Source/Negotiate.php:228:55: PossiblyNullOperand: Cannot concatenate with a possibly null null|string (see https://psalm.dev/080)
PossiblyUnusedMethod: src/Auth/Source/Negotiate.php#L46
src/Auth/Source/Negotiate.php:46:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\negotiateext\Auth\Source\Negotiate::__construct (see https://psalm.dev/087)