Skip to content

Fix sniffer-issues #212

Fix sniffer-issues

Fix sniffer-issues #212

Triggered via push April 24, 2025 15:05
Status Failure
Total duration 3m 6s
Artifacts

php.yml

on: push
Matrix: PHP-Linter
Linter  /  ecmascript-linter
Linter / ecmascript-linter
Linter  /  json-linter
Linter / json-linter
Linter  /  style-linter
Linter / style-linter
Linter  /  yaml-linter
Linter / yaml-linter
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
8s
Code coverage
Quality control
53s
Quality control
Security checks
17s
Security checks
Cleanup artifacts
6s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 3 warnings
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L281
tests/src/Controller/NegotiateControllerTest.php:281:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_270_7984::getbyid should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L276
tests/src/Controller/NegotiateControllerTest.php:276:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_270_7984::authenticate should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L253
tests/src/Controller/NegotiateControllerTest.php:253:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_252_7343::loadstate should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L215
tests/src/Controller/NegotiateControllerTest.php:215:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_214_6096::loadstate should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L189
tests/src/Controller/NegotiateControllerTest.php:189:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_178_5160::getbyid should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L184
tests/src/Controller/NegotiateControllerTest.php:184:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_178_5160::authenticate should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L161
tests/src/Controller/NegotiateControllerTest.php:161:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_160_4507::loadstate should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L61
tests/src/Controller/NegotiateControllerTest.php:61:13: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\_home_runner_work_simplesamlphp_module_negotiate_simplesamlphp_module_negotiate_tests_src_Controller_NegotiateControllerTest_php_60_1428::debug should have the "Override" attribute (see https://psalm.dev/358)
MissingOverrideAttribute: tests/src/Controller/NegotiateControllerTest.php#L44
tests/src/Controller/NegotiateControllerTest.php:44:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\negotiate\Controller\NegotiateControllerTest::setup should have the "Override" attribute (see https://psalm.dev/358)
UnusedClass: tests/src/Controller/NegotiateControllerTest.php#L26
tests/src/Controller/NegotiateControllerTest.php:26:7: UnusedClass: Class SimpleSAML\Test\Module\negotiate\Controller\NegotiateControllerTest is never used (see https://psalm.dev/075)
ImplicitToStringCast: src/Auth/Source/Negotiate.php#L409
src/Auth/Source/Negotiate.php:409:64: ImplicitToStringCast: Right side of concat op expects string, 'SimpleSAML\Error\Exception' provided with a __toString method (see https://psalm.dev/060)
UnnecessaryVarAnnotation: src/Auth/Source/Negotiate.php#L367
src/Auth/Source/Negotiate.php:367:24: UnnecessaryVarAnnotation: The @var SimpleSAML\Auth\Source|null annotation for $source is unnecessary (see https://psalm.dev/212)
PossiblyInvalidArrayAccess: src/Auth/Source/Negotiate.php#L199
src/Auth/Source/Negotiate.php:199:33: PossiblyInvalidArrayAccess: Cannot access array value on non-array variable of type false (see https://psalm.dev/109)
PossiblyInvalidArrayAccess: src/Auth/Source/Negotiate.php#L199
src/Auth/Source/Negotiate.php:199:27: PossiblyInvalidArrayAccess: Cannot access array value on non-array variable of type false (see https://psalm.dev/109)
PossiblyUndefinedVariable: src/Auth/Source/Negotiate.php#L181
src/Auth/Source/Negotiate.php:181:30: PossiblyUndefinedVariable: Possibly undefined variable $auth, first seen on line 159 (see https://psalm.dev/018)
PossiblyFalseArgument: src/Auth/Source/Negotiate.php#L157
src/Auth/Source/Negotiate.php:157:41: PossiblyFalseArgument: Argument 1 of version_compare cannot be false, possibly string value expected (see https://psalm.dev/104)
MissingOverrideAttribute: src/Auth/Source/Negotiate.php#L106
src/Auth/Source/Negotiate.php:106:5: MissingOverrideAttribute: Method SimpleSAML\Module\negotiate\Auth\Source\Negotiate::authenticate should have the "Override" attribute (see https://psalm.dev/358)
MissingClassConstType: src/Auth/Source/Negotiate.php#L39
src/Auth/Source/Negotiate.php:39:18: MissingClassConstType: Class constant "SimpleSAML\Module\negotiate\Auth\Source\Negotiate::AUTHID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: src/Auth/Source/Negotiate.php#L37
src/Auth/Source/Negotiate.php:37:18: MissingClassConstType: Class constant "SimpleSAML\Module\negotiate\Auth\Source\Negotiate::STAGEID" should have a declared type. (see https://psalm.dev/359)
ClassMustBeFinal: src/Auth/Source/Negotiate.php#L34
src/Auth/Source/Negotiate.php:34:7: ClassMustBeFinal: Class SimpleSAML\Module\negotiate\Auth\Source\Negotiate is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
ClassMustBeFinal: tests/src/Controller/NegotiateControllerTest.php#L26
tests/src/Controller/NegotiateControllerTest.php:26:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\negotiate\Controller\NegotiateControllerTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
UnusedClass: tests/src/Controller/NegotiateControllerTest.php#L26
tests/src/Controller/NegotiateControllerTest.php:26:7: UnusedClass: Class SimpleSAML\Test\Module\negotiate\Controller\NegotiateControllerTest is never used (see https://psalm.dev/075)
PossiblyUnusedMethod: src/Auth/Source/Negotiate.php#L74
src/Auth/Source/Negotiate.php:74:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\negotiate\Auth\Source\Negotiate::__construct (see https://psalm.dev/087)