-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: is there a maintainer to review a major upgrade? #186
Comments
@VividLemon Hey, thanks for the proposal! Yes we'd love to have this PR as we also want to move to Vue3 and Typescript for a while but just don't have enough experiences and time to do that yet ... |
I have a good amount of experience with both tools, however, my biggest issue that I believe I will encounter is converting that webpack script over to Vite. Some of the stuff is a bit over my head, I haven't used webpack in a long time, and some of the plugins I am not sure if there are Vite equivalents. It is possible, and even encouraged for Vue 2 apps to use Vite instead of vue-cli & webpack, so that PR can come before a Vue 3 upgrade. If memory serves, you were the one that wrote the script a number of years ago, when reviewing the commits with GitLens. If you'd like to, it would be a large help if you or someone else were to do that conversion for me. |
@VividLemon the project was bootstrapped using a vue extension boilerplate and we got the webpack config from there ... |
Some stuff is basic, yes, but some stuff is more specific to, what seems like browser extensions. Such as all of this code that I don't exactly know what is doing Or all of this |
@VividLemon these lines were added to generate a beta build for SL. When the beta build is run, it'll replace the extension name, icons to differentiate it with the production build. |
If I were to create a PR that did the following:
Would a maintainer be available to review this PR?
I'm not expecting this to come soon. I'm expecting this to be a challenging PR. It's a specifically challenging spot to resolve any outdated dependencies that haven't been updated to Vue 3, assuming there even are any. I see there are a few dependencies that I haven't heard of, vue-toasted, vue-js-modal, etc. If there are no Vue 3 variants, I would not be sure how to proceed unless given the freedom to simply make the creative decision to remove and replace them.
However, I would like to know in advance if anyone is here to review the PR 👀
The text was updated successfully, but these errors were encountered: