-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
BugIssues that report incorrect or undesirable behaviour(s)Issues that report incorrect or undesirable behaviour(s)Priority: 1EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.
Description
Summary
When invalid credentials are passed to SALClient.authenticate, the exception which is raised is sal.core.exception.InvalidResponse("The server did not return an authentication token"). It would be better if an AuthenticationFailed was raised.
Possible fixes
Ideally _handle_error could be used to address this, but raise an InvalidReponse if the response is both invalid and not a 401 error.
Metadata
Metadata
Assignees
Labels
BugIssues that report incorrect or undesirable behaviour(s)Issues that report incorrect or undesirable behaviour(s)Priority: 1EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.EVENTUAL: A low priority issue that is unlikely to be addressed until the priority increases.