Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtectEditing breaks Simpla elements in shadow roots #17

Open
madeleineostoja opened this issue May 11, 2017 · 0 comments
Open

ProtectEditing breaks Simpla elements in shadow roots #17

madeleineostoja opened this issue May 11, 2017 · 0 comments
Assignees
Labels

Comments

@madeleineostoja
Copy link

Right now protectEditing doesn't take shadow trees into account, which means that any elements that lie inside one have all pointer events disabled (from the shadow root host) and are broken.

protectEditing should automatically spin up new observers for any shadow roots it comes across, not just disable the whole tree. This needs to be fixed ASAP though, and if that requires the WC v1 registry to work well, then as an interim measure we should check if an element is a shadow host, and if so leave it alone. Better to have unprotected clicks in shadow roots than kill Simpla elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants