-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util.protontricks does not work on first run #19
Comments
Something definitely wrong with Suggestions:
Not tested deeper, because on already configured game it somehow works, but definitely |
@pchome I'd like for util.protontricks to use Proton wine, but by the time the user_settings.py is sourced the Proton wineserver is already running and I was getting conflicts with winetricks trying to start the wineserver again. I'll try working on it again and see where I can get. I don't think I had WINELOADER defined, that could have been the problem. I think using Proton wine will probably fix the issue of having to run twice. Protonfixes should be skipping the early steps here. The env variables will still get dumped to stderr if debug is imported, since that's been helpful for troubleshooting. The only issue with using @dreamer Uplay has other issues as well that I've seen causing login issues. SSL is kind of broken in steam-runtime because of an older version of libgnutls. For now I've been 'replacing' the uplay dlls with a local gamefix just to be able to play, but it might be fixable using LD_PRELOAD. EDIT: I just read that the Uplay connectivity might be fixed in Proton 3.16-1, but I'm still running 3.7 Beta installed by the client. Can you post a log for Valiant Hearts for first & second run on an fresh prefix? |
@simons-public I have connection issues worked out already - exactly by copying working gnutls into new directory and adding it to LD_LIBRARY_PATH. Uplay needs 32-bit version of gnutls to work. If corefonts were installed before Uplay starts for the first time then it would work quite all right. I'll try to see if just copying font files into prefix might work good enough. |
@simons-public I saw likely related error in logs:
Looks like not matching protocol versions for running @dreamer |
@dreamer I like your idea of linking the font files directly, I've been thinking of working it in as a default for protonfixes since so many games require fonts and hardlinking takes no space or time anyway. I can't really think of any downsides to always having the MS fonts in a prefix. |
@pchome That's exactly the error I was getting using proton wine, I'll refactor util.protontricks making sure it uses all the required environment variables and test it as soon as I have some time. |
@dreamer Ok, so util.protontricks is properly using Proton's wine now, and corefonts automatically get linked to |
@pchome Can you expand on the zenity loader being broken? I'm not seeing multiple cycles of it in my logs |
you mean Proton's WINE ?
I should do a cleanup and merge changes first, an than retest. I better should retest this with recent changes, to be sure it still an issue. I'll report if so. |
Sorry, yes Proton's wine |
@dreamer Reading winetricks source just now, I think part of the reason it takes a second run after winetricks is because winetricks kills the wineserver with |
@dreamer I tested with rerunning wineserver at the end and it ended up causing steam to think the game was running after termination. However, when I started testing with the latest Proton 3.16-4 I noticed I wasn't having the issue anymore. Can you test with Proton 3.16-4 and let me know if you're still having the issue? |
Sometimes `winetricks` performs a strange things, so very likely it should wait for `wineserver` to quit. Not sure, but it can also help simons-public#19, or otherwise there should be one more check for a prefix existence.
* Possible fix for a rare winetricks fail Sometimes `winetricks` performs a strange things, so very likely it should wait for `wineserver` to quit. Not sure, but it can also help #19, or otherwise there should be one more check for a prefix existence. * Fix: Used full path to Proton's wineserver
* Possible fix for a rare winetricks fail Sometimes `winetricks` performs a strange things, so very likely it should wait for `wineserver` to quit. Not sure, but it can also help simons-public#19, or otherwise there should be one more check for a prefix existence. * Fix: Used full path to Proton's wineserver
Describe the bug
I am developing a gamefix for Valiant Hearts, which needs corefonts installed (as all Uplay titles do) and found out, that
util.protontricks('corefonts')
does not work for me.What is interesting: it never works on on first run, but always on second one - but it's not good enough, because Uplay won't show any interface without corefonts installed, thus user won't be able to log in to start the game.
Any ideas how to proceed?
The text was updated successfully, but these errors were encountered: