Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toolbar button #9

Open
BlueMax opened this issue Feb 15, 2014 · 7 comments
Open

Add a toolbar button #9

BlueMax opened this issue Feb 15, 2014 · 7 comments

Comments

@BlueMax
Copy link

BlueMax commented Feb 15, 2014

Can you implement a toggle button for the Firefox button bar?

@simonlindholm
Copy link
Owner

Sounds like a reasonable idea. Same behavior as Ctrl+M, yes? The only question is that of which icon to use... I pushed a prototype to the toolbar-button branch, which works only on Australis.

@BlueMax
Copy link
Author

BlueMax commented Feb 16, 2014

Thanks. Sounds good.
Couldn't resist to test it on Fx27 anyway but yes, it doesn't work. :) Good to know its coming.

@simonlindholm
Copy link
Owner

(Fx29 has been released, but I still have no good icon. :( )

@BlueMax
Copy link
Author

BlueMax commented May 25, 2014

Working nicely here. Thanks for that. :)
I think the icon is ok. Clearly distinguishable from the others.

@simonlindholm simonlindholm changed the title Toggle button for button bar Add a toolbar button Jun 1, 2014
@simonlindholm
Copy link
Owner

This could work (from @sootn):
skrmbild frn 2014-06-01 15 34 45

@BlueMax
Copy link
Author

BlueMax commented Jun 6, 2014

With the v1.2 update the icon is gone? Is that intended?

@simonlindholm
Copy link
Owner

The icon never landed in 1.2 (hence this issue still being open). I've updated the "toolbar-button" branch though, to be on top of 1.2 and include the icon above, so feel free to use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants