-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mock
function to overrides non-configurable props
#101
Conversation
Can someone review this π ? |
I could very much use this PR. I'm stuck on 0.6.0 until there's some way to mock |
Hey @simonihmig! I know you probably have more important things to do π But is there any chance we could get this PR merged? It'd be very helpful ππ» Thanks in advance for all your work! |
Hey folks, so the thing here is that this is based (contains those commits) on #100, which had some longer discussions a (even longer) while ago, and which seems to not have been finalized. I am really not aware anymore of the exact state of those PRs, would need some time to dig into it again. AFAIR the work in #100 is technically required before we can land this, right? @buschtoens what about you, are you still interested in working on these? Somehow the momentum was interrupted at some point unfortunately, and the PRs became dormant. Not intending to blame anyone here, not having the time to continue work would be totally understandable, just want to figure out if/how we can move this forward! |
Sorry @boydkr for the late reply. Could you explain why you need this PR to mock |
Closing this as the work is abandoned and way out of sync. |
Based on #100. Fixes #99.
I don't know, if
mock
is the best name. Maybeoverride
? I don't know. π€·ββοΈ π