Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields in CompositeFields in parameterFields() don't work for filtering. #138

Open
GuySartorelli opened this issue Oct 6, 2021 · 0 comments
Open

Fields in CompositeFields in parameterFields() don't work for filtering. #138

GuySartorelli opened this issue Oct 6, 2021 · 0 comments
Labels
affects/v4 impact/low type/enhancement

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 6, 2021 •
edited
Loading

The getCMSFields in Report loops through each field returned from the parameterFields method and modifies the name of the field. The new name is then picked up in ReportAdmin.js in order to trigger the filtering.

Fields inside CompositeFields are ignored by this - developers must either override the getCMSFields method, or set the field name for those fields as filters[$FieldName] themselves if they want them to be picked up.

PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 impact/low type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli