Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $startIndex param on Pos method #1221

Open
4 tasks done
nedmas opened this issue Jul 20, 2024 · 1 comment
Open
4 tasks done

Support $startIndex param on Pos method #1221

nedmas opened this issue Jul 20, 2024 · 1 comment

Comments

@nedmas
Copy link

nedmas commented Jul 20, 2024

Description

The Pos method used in SilverStripe template loops supports adjusting the starting number of the position index (see silverstripe-framework/src/View/SSViewer_BasicIteratorSupport.php). It would be good to add feature parity for those wishing to use zero based indexes ;)

Additional context or points of discussion

No response

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)

PRs

@GuySartorelli
Copy link
Member

Hiya.
As mentioned in your original PR, this can only be done in a major release. Feel free to open a new pull request targeting the 6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants