You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RootURLController is currently hardcoded to work with SiteTree. It's not inconceivable that someone might want to route to a DataObject that isn't managed in the site tree as the "home" route.
Making this class more generic removes some friction from that use case.
Acceptance Criteria
Make this controller work with other DataObject subclasses
TO DECIDE
Arguably this doesn't open much opportunity if we don't move some stuff around as well - but what should we move, and to where?
Do we want to move this to silverstripe/framework?
Do we want to move this to a new module (along with ModelAsController and ContentController)?
Do we want to keep these here, and move SiteTree and CMSMain to a new silverstripe/pages module?
The text was updated successfully, but these errors were encountered:
RootURLController
is currently hardcoded to work withSiteTree
. It's not inconceivable that someone might want to route to aDataObject
that isn't managed in the site tree as the "home" route.Making this class more generic removes some friction from that use case.
Acceptance Criteria
DataObject
subclassesTO DECIDE
Arguably this doesn't open much opportunity if we don't move some stuff around as well - but what should we move, and to where?
silverstripe/framework
?ModelAsController
andContentController
)?SiteTree
andCMSMain
to a newsilverstripe/pages
module?The text was updated successfully, but these errors were encountered: