Skip to content

Commit 30f432d

Browse files
Fixes issue with translate and temp models (#805)
1 parent 79bc431 commit 30f432d

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

silnlp/nmt/experiment.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,10 @@ def translate(self):
9292

9393
for config in translate_configs.get("translate", []):
9494
translator = TranslationTask(
95-
name=self.name, checkpoint=config.get("checkpoint", "last"), commit=self.commit
95+
name=self.name,
96+
checkpoint=config.get("checkpoint", "last"),
97+
save_checkpoints=self.save_checkpoints,
98+
commit=self.commit,
9699
)
97100

98101
# Backwards compatibility

silnlp/nmt/hugging_face_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1700,7 +1700,7 @@ def _create_inference_model(
17001700
checkpoint_path, _ = self.get_checkpoint_path(ckpt)
17011701
model_name = str(checkpoint_path)
17021702
else:
1703-
LOGGER.warn("Model has no checkpoints. Using base model.")
1703+
LOGGER.warning("Model has no checkpoints. Using base model.")
17041704
model_name = self._config.model
17051705

17061706
dtype = torch.bfloat16 if self._is_t5 else torch.float16

silnlp/nmt/translate.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ def translate(
4141
class TranslationTask:
4242
name: str
4343
checkpoint: Union[str, int] = "last"
44+
save_checkpoints: bool = False
4445
clearml_queue: Optional[str] = None
4546
commit: Optional[str] = None
4647

@@ -266,6 +267,7 @@ def _init_translation_task(self, experiment_suffix: str) -> Tuple[Translator, Co
266267
project_suffix="_infer",
267268
experiment_suffix=experiment_suffix,
268269
commit=self.commit,
270+
use_default_model_dir=self.save_checkpoints,
269271
)
270272
self.name = clearml.name
271273

0 commit comments

Comments
 (0)