From 2b76389a0fa23f8bd19aefc9e20ff833d3a2011c Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Thu, 24 Jul 2025 17:36:49 +0700
Subject: [PATCH 1/9] Fix `svelte-check` warning about enableSourcemap

Sourcemaps are always on in Svelte 5, no need to enable them explicitly.

We'll leave the line in the config file, commented out, in case anyone
wonders about it.
---
 frontend/svelte.config.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/svelte.config.js b/frontend/svelte.config.js
index 7ce916aa7f..24a8a3e4e3 100644
--- a/frontend/svelte.config.js
+++ b/frontend/svelte.config.js
@@ -5,7 +5,7 @@ import { vitePreprocess } from '@sveltejs/vite-plugin-svelte';
 const config = {
   compilerOptions: {
     warningFilter: (warning) => warning.code != 'element_invalid_self_closing_tag',
-    enableSourcemap: true
+    // enableSourcemap: true // Sourcemaps are always on in Svelte 5, no need to enable them explicitly
   },
   onwarn: (warning, handler) => {
     // eslint-plugin-svelte needs its own warning filter, duplicating the one from compilerOptions

From 4fd8a8b9afb580a833573cca4e2223e87893a3c3 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Thu, 24 Jul 2025 17:39:37 +0700
Subject: [PATCH 2/9] Fix missing translation

This was caught by the svelte/no-useless-mustaches rule
---
 .../(authenticated)/project/[project_code]/AddPurpose.svelte    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/routes/(authenticated)/project/[project_code]/AddPurpose.svelte b/frontend/src/routes/(authenticated)/project/[project_code]/AddPurpose.svelte
index 4fd9fb4940..f92b922f26 100644
--- a/frontend/src/routes/(authenticated)/project/[project_code]/AddPurpose.svelte
+++ b/frontend/src/routes/(authenticated)/project/[project_code]/AddPurpose.svelte
@@ -68,6 +68,6 @@
     </Select>
   {/snippet}
   {#snippet submitText()}
-    <span>{'Add Purpose'}</span>
+    <span>{$t('project_page.add_purpose.add_button')}</span>
   {/snippet}
 </FormModal>

From 8ac5c84e5dc3a5265513af8ae99fab60e57cfa68 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Thu, 24 Jul 2025 17:40:05 +0700
Subject: [PATCH 3/9] Fix remaining svelte/no-useless-mustaches errors

The two remaining svelte/no-useless-mustaches errors were auto-fixed by
the eslint rule.
---
 frontend/src/routes/(authenticated)/project/create/+page.svelte | 2 +-
 frontend/src/routes/(unauthenticated)/register/+page.svelte     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/routes/(authenticated)/project/create/+page.svelte b/frontend/src/routes/(authenticated)/project/create/+page.svelte
index a9485be059..2d395e2d73 100644
--- a/frontend/src/routes/(authenticated)/project/create/+page.svelte
+++ b/frontend/src/routes/(authenticated)/project/create/+page.svelte
@@ -238,7 +238,7 @@
       <ProjectTypeSelect bind:value={$form.type} error={$errors.type} />
 
       <Select id="org" label={$t('project.create.org')} bind:value={$form.orgId} error={$errors.orgId}>
-        <option value={''}>{$t('project_page.organization.placeholder')}</option>
+        <option value="">{$t('project_page.organization.placeholder')}</option>
         {#each myOrgs as org}
           <option value={org.id}>{org.name}</option>
         {/each}
diff --git a/frontend/src/routes/(unauthenticated)/register/+page.svelte b/frontend/src/routes/(unauthenticated)/register/+page.svelte
index 4f18eb7d07..10cccabcc1 100644
--- a/frontend/src/routes/(unauthenticated)/register/+page.svelte
+++ b/frontend/src/routes/(unauthenticated)/register/+page.svelte
@@ -13,7 +13,7 @@
 
 <TitlePage title={$t('register.title')}>
   <div class="flex flex-col pb-2">
-    <RegisterWithGoogleButton href={`/api/login/google`}/>
+    <RegisterWithGoogleButton href="/api/login/google"/>
   </div>
   <div class="divider lowercase">{$t('common.or')}</div>
   <CreateUser handleSubmit={register} onSubmitted={onSubmit} />

From 33b567d8276615c03d9b2949fe4595867d79fdf0 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Thu, 24 Jul 2025 17:56:18 +0700
Subject: [PATCH 4/9] Fix eslint errors in Lexbox admin UI

FW Lite UI (frontend/viewer) will be next
---
 frontend/eslint.config.js                              |  8 --------
 frontend/src/lib/components/HgLogView.svelte           |  2 +-
 frontend/src/lib/components/ProjectList.svelte         |  2 +-
 .../Projects/ProjectConfidentialityFilterSelect.svelte |  2 +-
 .../src/lib/components/Projects/ProjectFilter.svelte   |  2 +-
 .../src/lib/components/Projects/ProjectTable.svelte    |  2 +-
 .../lib/components/Projects/WritingSystemList.svelte   |  2 +-
 frontend/src/lib/components/TrainTracks.svelte         |  4 ++--
 frontend/src/lib/components/Users/UserFilter.svelte    | 10 +++++-----
 frontend/src/lib/components/Users/UserProjects.svelte  |  2 +-
 frontend/src/lib/components/Users/UserTable.svelte     |  2 +-
 frontend/src/lib/forms/DisplayLanguageSelect.svelte    |  2 +-
 frontend/src/lib/forms/ProjectTypeSelect.svelte        |  2 +-
 frontend/src/lib/forms/RadioButtonGroup.svelte         |  2 +-
 frontend/src/lib/forms/UserTypeSelect.svelte           |  2 +-
 frontend/src/lib/forms/UserTypeahead.svelte            |  2 +-
 frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte |  2 +-
 .../src/routes/(authenticated)/admin/AdminTabs.svelte  |  2 +-
 .../(authenticated)/admin/EditUserAccount.svelte       |  2 +-
 .../src/routes/(authenticated)/authorize/+page.svelte  |  4 ++--
 .../org/[org_id]/BulkAddOrgMembers.svelte              |  6 +++---
 .../(authenticated)/org/[org_id]/OrgMemberTable.svelte |  2 +-
 .../routes/(authenticated)/org/[org_id]/OrgTabs.svelte |  2 +-
 .../src/routes/(authenticated)/org/list/+page.svelte   |  2 +-
 .../project/[project_code]/AddOrganization.svelte      |  2 +-
 .../[project_code]/BulkAddProjectMembers.svelte        |  6 +++---
 .../routes/(authenticated)/project/create/+page.svelte |  4 ++--
 frontend/src/routes/+error.svelte                      |  2 +-
 frontend/src/routes/email/tester/+page@.svelte         |  2 +-
 29 files changed, 39 insertions(+), 47 deletions(-)

diff --git a/frontend/eslint.config.js b/frontend/eslint.config.js
index 16be318dfa..20decc3ca4 100644
--- a/frontend/eslint.config.js
+++ b/frontend/eslint.config.js
@@ -143,12 +143,4 @@ export default [
       }
     },
   },
-  {
-    // TEMPORARY IGNORES, to be gotten rid of as soon as possible - 2025-07-24 RM
-    files: ['**/*.svelte', '**/*.svelte.ts'],
-    rules: {
-      'svelte/require-each-key': 'off',
-      'svelte/no-useless-mustaches': 'off',
-    },
-  },
 ];
diff --git a/frontend/src/lib/components/HgLogView.svelte b/frontend/src/lib/components/HgLogView.svelte
index 4b3c0fb9a4..51163b5a1b 100644
--- a/frontend/src/lib/components/HgLogView.svelte
+++ b/frontend/src/lib/components/HgLogView.svelte
@@ -136,7 +136,7 @@
   </thead>
   <tbody>
     {#if logEntries?.length}
-      {#each expandedLog as log, idx}
+      {#each expandedLog as log, idx (log.node)}
         <tr>
           {#if idx === 0}
             <td class="py-0 w-0" rowspan="1000000">
diff --git a/frontend/src/lib/components/ProjectList.svelte b/frontend/src/lib/components/ProjectList.svelte
index 6b208bb430..927db94868 100644
--- a/frontend/src/lib/components/ProjectList.svelte
+++ b/frontend/src/lib/components/ProjectList.svelte
@@ -14,7 +14,7 @@
 </script>
 
 <div class="grid grid-cols-1 xs:grid-cols-2 sm:grid-cols-3 auto-rows-fr gap-2 md:gap-4 max-xs:justify-items-center">
-  {#each projects as project}
+  {#each projects as project (project.id)}
     {#if project.isDraft}
       <div class="draft card aspect-square bg-base-200 overflow-hidden">
         <div class="bg" style="background-image: url('{getProjectTypeIcon(project.type)}')"></div>
diff --git a/frontend/src/lib/components/Projects/ProjectConfidentialityFilterSelect.svelte b/frontend/src/lib/components/Projects/ProjectConfidentialityFilterSelect.svelte
index f41ef4a611..4b3f55c7a5 100644
--- a/frontend/src/lib/components/Projects/ProjectConfidentialityFilterSelect.svelte
+++ b/frontend/src/lib/components/Projects/ProjectConfidentialityFilterSelect.svelte
@@ -21,7 +21,7 @@
 <div class="relative">
   <Select {...rest} label={$t('project.confidential.confidentiality')} helpLink={helpLinks.confidentiality} bind:value>
     <option value={undefined}>{$t('common.any')}</option>
-    {#each Object.entries(options) as [value, label]}
+    {#each Object.entries(options) as [value, label] (value)}
       <option {value}>{$t(label)}</option>
     {/each}
   </Select>
diff --git a/frontend/src/lib/components/Projects/ProjectFilter.svelte b/frontend/src/lib/components/Projects/ProjectFilter.svelte
index 5cebab0d9d..56e728a4e0 100644
--- a/frontend/src/lib/components/Projects/ProjectFilter.svelte
+++ b/frontend/src/lib/components/Projects/ProjectFilter.svelte
@@ -98,7 +98,7 @@
   {loading}
 >
   {#snippet activeFilterSlot({ activeFilters })}
-    {#each activeFilters as filter}
+    {#each activeFilters as filter (filter.key)}
       {#if filter.key === 'projectType'}
         <ActiveFilter {filter}>
           <ProjectTypeIcon type={filter.value} />
diff --git a/frontend/src/lib/components/Projects/ProjectTable.svelte b/frontend/src/lib/components/Projects/ProjectTable.svelte
index 7868f3599a..bce5b16294 100644
--- a/frontend/src/lib/components/Projects/ProjectTable.svelte
+++ b/frontend/src/lib/components/Projects/ProjectTable.svelte
@@ -55,7 +55,7 @@
       </tr>
     </thead>
     <tbody>
-      {#each projects as project}
+      {#each projects as project (project.id)}
         <tr>
           {#if isColumnVisible('name')}
             <td>
diff --git a/frontend/src/lib/components/Projects/WritingSystemList.svelte b/frontend/src/lib/components/Projects/WritingSystemList.svelte
index 5d33428974..8863dc64eb 100644
--- a/frontend/src/lib/components/Projects/WritingSystemList.svelte
+++ b/frontend/src/lib/components/Projects/WritingSystemList.svelte
@@ -13,7 +13,7 @@
 <div class="w-full">
   {#if writingSystems.length > 0}
     <BadgeList>
-      {#each writingSystems as ws}
+      {#each writingSystems as ws (ws.tag)}
         <WritingSystemBadge tag={ws.tag} isActive={ws.isActive} isDefault={ws.isDefault} />
       {/each}
     </BadgeList>
diff --git a/frontend/src/lib/components/TrainTracks.svelte b/frontend/src/lib/components/TrainTracks.svelte
index 8cdbee9351..276f8a8381 100644
--- a/frontend/src/lib/components/TrainTracks.svelte
+++ b/frontend/src/lib/components/TrainTracks.svelte
@@ -113,10 +113,10 @@
 {#if circles?.length > 0}
   <svg width={maxWidth} height="0" style="height: 100%">
     {#if rowHeights?.length > 0}
-      {#each curves as curve}
+      {#each curves as curve (curve)}
         <path fill="none" stroke={curve.color} stroke-width="1.5" d={curve.d} />
       {/each}
-      {#each svgDots as c}
+      {#each svgDots as c (c)}
         <circle cx={c.x} cy={c.y} r={circleSize} fill={c.color} stroke="none" style="" />
       {/each}
     {/if}
diff --git a/frontend/src/lib/components/Users/UserFilter.svelte b/frontend/src/lib/components/Users/UserFilter.svelte
index dd4c9c542e..2e606c99e7 100644
--- a/frontend/src/lib/components/Users/UserFilter.svelte
+++ b/frontend/src/lib/components/Users/UserFilter.svelte
@@ -54,8 +54,8 @@
   {loading}
 >
   {#snippet activeFilterSlot({ activeFilters })}
-  
-      {#each activeFilters as filter}
+
+      {#each activeFilters as filter (filter.key)}
         {#if filter.key === 'userType' && filter.value}
           <ActiveFilter {filter}>
             {#if filter.value === 'admin'}
@@ -76,10 +76,10 @@
           </ActiveFilter>
         {/if}
       {/each}
-    
+
   {/snippet}
   {#snippet filterSlot()}
-  
+
       <h2 class="card-title">{$t('admin_dashboard.user_filter.title')}</h2>
       {#if filterEnabled('userType')}
         <div class="form-control">
@@ -97,6 +97,6 @@
           </label>
         </div>
       {/if}
-    
+
   {/snippet}
 </FilterBar>
diff --git a/frontend/src/lib/components/Users/UserProjects.svelte b/frontend/src/lib/components/Users/UserProjects.svelte
index 4d74392e99..d56841b331 100644
--- a/frontend/src/lib/components/Users/UserProjects.svelte
+++ b/frontend/src/lib/components/Users/UserProjects.svelte
@@ -73,7 +73,7 @@
         </tr>
       </thead>
       <tbody>
-        {#each projects as proj}
+        {#each projects as proj (proj.id)}
           {@const isManager = proj.memberRole === ProjectRole.Manager}
           <tr>
             <td class="p-0 w-4">
diff --git a/frontend/src/lib/components/Users/UserTable.svelte b/frontend/src/lib/components/Users/UserTable.svelte
index 7191608461..f22affe7b8 100644
--- a/frontend/src/lib/components/Users/UserTable.svelte
+++ b/frontend/src/lib/components/Users/UserTable.svelte
@@ -30,7 +30,7 @@
     </tr>
   </thead>
   <tbody>
-    {#each shownUsers as user}
+    {#each shownUsers as user (user.id)}
       <tr>
         <td>
           <div class="flex items-center gap-2 max-w-40 @xl:max-w-52">
diff --git a/frontend/src/lib/forms/DisplayLanguageSelect.svelte b/frontend/src/lib/forms/DisplayLanguageSelect.svelte
index e1c57bd8c2..17a93cd5be 100644
--- a/frontend/src/lib/forms/DisplayLanguageSelect.svelte
+++ b/frontend/src/lib/forms/DisplayLanguageSelect.svelte
@@ -25,7 +25,7 @@
     <!-- Make sure we don't overwrite persisted locales that we don't support yet -->
     <option {value}>{value} ({$t('account_settings.language.not_supported')})</option>
   {/if}
-  {#each availableLocales as locale}
+  {#each availableLocales as locale (locale)}
     <option value={locale}>{localNames[locale] ?? locale}</option>
   {/each}
 </Select>
diff --git a/frontend/src/lib/forms/ProjectTypeSelect.svelte b/frontend/src/lib/forms/ProjectTypeSelect.svelte
index 048eca8920..a74556080a 100644
--- a/frontend/src/lib/forms/ProjectTypeSelect.svelte
+++ b/frontend/src/lib/forms/ProjectTypeSelect.svelte
@@ -25,7 +25,7 @@
     {#if undefinedOptionLabel}
       <option value={undefined}>{undefinedOptionLabel}</option>
     {/if}
-    {#each types as type}
+    {#each types as type (type)}
       <option value={type}><FormatProjectType {type} /></option>
     {/each}
     {#if includeUnknown}
diff --git a/frontend/src/lib/forms/RadioButtonGroup.svelte b/frontend/src/lib/forms/RadioButtonGroup.svelte
index e9009d893e..9fd3b9c389 100644
--- a/frontend/src/lib/forms/RadioButtonGroup.svelte
+++ b/frontend/src/lib/forms/RadioButtonGroup.svelte
@@ -39,7 +39,7 @@
   <div class="legend" id={`label-${id}`}>
     {label}
   </div>
-  {#each buttons as button}
+  {#each buttons as button (button.value)}
     <div class="form-control w-full">
       <label class="label cursor-pointer justify-normal pb-0">
         <input {id} type="radio" bind:group={value} value={button.value} class="radio mr-2 {variant ?? ''}" />
diff --git a/frontend/src/lib/forms/UserTypeSelect.svelte b/frontend/src/lib/forms/UserTypeSelect.svelte
index 55ca0f1abe..33216a08ee 100644
--- a/frontend/src/lib/forms/UserTypeSelect.svelte
+++ b/frontend/src/lib/forms/UserTypeSelect.svelte
@@ -22,7 +22,7 @@
     {#if undefinedOptionLabel}
       <option value={undefined}>{undefinedOptionLabel}</option>
     {/if}
-    {#each Object.entries(options) as [value, label]}
+    {#each Object.entries(options) as [value, label] (value)}
       <option {value}>{$t(label)}</option>
     {/each}
   </Select>
diff --git a/frontend/src/lib/forms/UserTypeahead.svelte b/frontend/src/lib/forms/UserTypeahead.svelte
index 55b4b743b7..4f13609c78 100644
--- a/frontend/src/lib/forms/UserTypeahead.svelte
+++ b/frontend/src/lib/forms/UserTypeahead.svelte
@@ -133,7 +133,7 @@
     />
     <div class="overlay-content">
       <ul class="menu p-0">
-      {#each filteredResults as user, idx}
+      {#each filteredResults as user, idx (user.id)}
         <li class={(highlightIdx == idx) ? 'p-0 bg-primary text-white' : 'p-0'}><button class="whitespace-nowrap" onclick={() => {
           setTimeout(() => selectUser(user));
         }}>{formatResult(user)}</button></li>
diff --git a/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte b/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte
index fccfca6d69..3c59488c16 100644
--- a/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte
+++ b/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte
@@ -9,7 +9,7 @@
 
 <div class="text-sm breadcrumbs p-0 max-xs:invisible">
   <ul>
-    {#each $crumbs as crumb}
+    {#each $crumbs as crumb (crumb)}
       <RenderElement tag="li" el={crumb}/>
     {/each}
   </ul>
diff --git a/frontend/src/routes/(authenticated)/admin/AdminTabs.svelte b/frontend/src/routes/(authenticated)/admin/AdminTabs.svelte
index e4d1419ccd..43073926ec 100644
--- a/frontend/src/routes/(authenticated)/admin/AdminTabs.svelte
+++ b/frontend/src/routes/(authenticated)/admin/AdminTabs.svelte
@@ -24,7 +24,7 @@
 
 <div role="tablist" class="hidden admin-tabs:flex tabs tabs-lifted tabs-lg overflow-x-auto">
   <div class="tab tab-divider"></div>
-  {#each adminTabs as tab}
+  {#each adminTabs as tab (tab)}
     {@const isActiveTab = activeTab === tab}
     <button
       onclick={() => onClickTab?.(tab)}
diff --git a/frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte b/frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte
index 5462ea8c52..f221a64480 100644
--- a/frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte
+++ b/frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte
@@ -145,7 +145,7 @@
       <div>
         Feature flags:
         <ul>
-          {#each allPossibleFlags as flag}
+          {#each allPossibleFlags as flag (flag)}
             <li>
               <label
                 ><input type="checkbox" name="featureFlags" value={flag} bind:group={$form!.featureFlags} />
diff --git a/frontend/src/routes/(authenticated)/authorize/+page.svelte b/frontend/src/routes/(authenticated)/authorize/+page.svelte
index ff8d247111..5aa2eb6477 100644
--- a/frontend/src/routes/(authenticated)/authorize/+page.svelte
+++ b/frontend/src/routes/(authenticated)/authorize/+page.svelte
@@ -30,7 +30,7 @@
       </div>
       <div class="bg-base-200/50 py-5 px-8">
         <div class="grid gap-x-3 gap-y-5" style="grid-template-columns: auto 1fr">
-          {#each data.scope?.split(' ') ?? [] as scope}
+          {#each data.scope?.split(' ') ?? [] as scope (scope)}
             {#if scope === 'profile'}
               <div class="grid grid-cols-subgrid col-span-full items-center">
                 <AuthenticatedUserIcon size="text-4xl" />
@@ -53,7 +53,7 @@
         </div>
       </div>
       <div>
-        {#each Object.entries(data.postback) as [key, value]}
+        {#each Object.entries(data.postback) as [key, value] (key)}
           <!--parameters required to resume the auth process-->
           <input type="hidden" name={key} {value} />
         {/each}
diff --git a/frontend/src/routes/(authenticated)/org/[org_id]/BulkAddOrgMembers.svelte b/frontend/src/routes/(authenticated)/org/[org_id]/BulkAddOrgMembers.svelte
index 783d1f8e28..2c2fe7f7e4 100644
--- a/frontend/src/routes/(authenticated)/org/[org_id]/BulkAddOrgMembers.svelte
+++ b/frontend/src/routes/(authenticated)/org/[org_id]/BulkAddOrgMembers.svelte
@@ -110,7 +110,7 @@
         {#if addedMembers.length > 0}
           <div class="mt-2">
             <BadgeList>
-              {#each addedMembers as user}
+              {#each addedMembers as user (user.username)}
                 <OrgMemberBadge member={{ name: user.username, role: user.role }} />
               {/each}
             </BadgeList>
@@ -125,7 +125,7 @@
         {#if notFoundMembers.length > 0}
           <div class="mt-2">
             <BadgeList>
-              {#each notFoundMembers as user}
+              {#each notFoundMembers as user (user.username)}
                 <OrgMemberBadge member={{ name: user.username, role: user.role }} />
               {/each}
             </BadgeList>
@@ -139,7 +139,7 @@
         </p>
         <div class="mt-2">
           <BadgeList>
-            {#each existingMembers as user}
+            {#each existingMembers as user (user.username)}
               <OrgMemberBadge member={{ name: user.username, role: user.role }} />
             {/each}
           </BadgeList>
diff --git a/frontend/src/routes/(authenticated)/org/[org_id]/OrgMemberTable.svelte b/frontend/src/routes/(authenticated)/org/[org_id]/OrgMemberTable.svelte
index 8d8917367f..9b9a1c5f98 100644
--- a/frontend/src/routes/(authenticated)/org/[org_id]/OrgMemberTable.svelte
+++ b/frontend/src/routes/(authenticated)/org/[org_id]/OrgMemberTable.svelte
@@ -58,7 +58,7 @@
       </tr>
     </thead>
     <tbody>
-      {#each shownUsers as member}
+      {#each shownUsers as member (member.id)}
         {@const memberUser = member.user}
         {@const isOrgAdmin = member.role === OrgRole.Admin}
         <tr>
diff --git a/frontend/src/routes/(authenticated)/org/[org_id]/OrgTabs.svelte b/frontend/src/routes/(authenticated)/org/[org_id]/OrgTabs.svelte
index a1407dc910..cf8ebe09b1 100644
--- a/frontend/src/routes/(authenticated)/org/[org_id]/OrgTabs.svelte
+++ b/frontend/src/routes/(authenticated)/org/[org_id]/OrgTabs.svelte
@@ -34,7 +34,7 @@
 
 <div role="tablist" class="flex tabs tabs-lifted tabs-lg overflow-x-auto">
   <div class="tab tab-divider"></div>
-  {#each visibleTabs as tab}
+  {#each visibleTabs as tab (tab)}
     {@const isActiveTab = activeTab === tab}
     <button onclick={() => activeTab = tab} role="tab" class:tab-active={isActiveTab} class="tab grow flex-1 basis-1/2">
       <h2 class="text-lg flex gap-4 items-center">
diff --git a/frontend/src/routes/(authenticated)/org/list/+page.svelte b/frontend/src/routes/(authenticated)/org/list/+page.svelte
index b1832b38d2..46a09f628e 100644
--- a/frontend/src/routes/(authenticated)/org/list/+page.svelte
+++ b/frontend/src/routes/(authenticated)/org/list/+page.svelte
@@ -149,7 +149,7 @@ TODO:
               </tr>
             {/if}
           {/if}
-          {#each [...myOrgs, ...otherOrgs] as org, i}
+          {#each [...myOrgs, ...otherOrgs] as org, i (org.id)}
             {@const isFirstOtherOrg = i === myOrgs.length}
             {#if showingMyOrgsHeader && isFirstOtherOrg}
               <tr>
diff --git a/frontend/src/routes/(authenticated)/project/[project_code]/AddOrganization.svelte b/frontend/src/routes/(authenticated)/project/[project_code]/AddOrganization.svelte
index 12797e9814..d0d242d0e0 100644
--- a/frontend/src/routes/(authenticated)/project/[project_code]/AddOrganization.svelte
+++ b/frontend/src/routes/(authenticated)/project/[project_code]/AddOrganization.svelte
@@ -53,7 +53,7 @@
   {/snippet}
   {#snippet children({ errors })}
     <Select id="org" label={$t('project_page.organization.title')} bind:value={$form!.orgId} error={errors.orgId}>
-      {#each orgList as org}
+      {#each orgList as org (org.id)}
         <option value={org.id}>{org.name}</option>
       {/each}
     </Select>
diff --git a/frontend/src/routes/(authenticated)/project/[project_code]/BulkAddProjectMembers.svelte b/frontend/src/routes/(authenticated)/project/[project_code]/BulkAddProjectMembers.svelte
index 2b32f60886..0c8e35e431 100644
--- a/frontend/src/routes/(authenticated)/project/[project_code]/BulkAddProjectMembers.svelte
+++ b/frontend/src/routes/(authenticated)/project/[project_code]/BulkAddProjectMembers.svelte
@@ -144,7 +144,7 @@
           {#if addedMembers.length > 0}
             <div class="mt-2">
               <BadgeList>
-                {#each addedMembers as user}
+                {#each addedMembers as user (user.username)}
                   <MemberBadge member={{ name: user.username, role: user.role }} />
                 {/each}
               </BadgeList>
@@ -159,7 +159,7 @@
           {#if createdMembers.length > 0}
             <div class="mt-2">
               <BadgeList>
-                {#each createdMembers as user}
+                {#each createdMembers as user (user.username)}
                   <MemberBadge member={{ name: user.username, role: user.role }} />
                 {/each}
               </BadgeList>
@@ -173,7 +173,7 @@
           </p>
           <div class="mt-2">
             <BadgeList>
-              {#each existingMembers as user}
+              {#each existingMembers as user (user.username)}
                 <MemberBadge member={{ name: user.username, role: user.role }} />
               {/each}
             </BadgeList>
diff --git a/frontend/src/routes/(authenticated)/project/create/+page.svelte b/frontend/src/routes/(authenticated)/project/create/+page.svelte
index 2d395e2d73..a37266a24c 100644
--- a/frontend/src/routes/(authenticated)/project/create/+page.svelte
+++ b/frontend/src/routes/(authenticated)/project/create/+page.svelte
@@ -239,7 +239,7 @@
 
       <Select id="org" label={$t('project.create.org')} bind:value={$form.orgId} error={$errors.orgId}>
         <option value="">{$t('project_page.organization.placeholder')}</option>
-        {#each myOrgs as org}
+        {#each myOrgs as org (org.id)}
           <option value={org.id}>{org.name}</option>
         {/each}
       </Select>
@@ -300,7 +300,7 @@
             <div class="legend" id="label-extra-projects">
               {$t('project.create.maybe_related')}
             </div>
-            {#each relatedProjects.current as proj}
+            {#each relatedProjects.current as proj (proj.id)}
               <div class="form-control w-full">
                 <label class="label cursor-pointer justify-normal pb-0">
                   <input
diff --git a/frontend/src/routes/+error.svelte b/frontend/src/routes/+error.svelte
index bb50a26901..172d6ee369 100644
--- a/frontend/src/routes/+error.svelte
+++ b/frontend/src/routes/+error.svelte
@@ -9,7 +9,7 @@
 
 {#if page.data.user}
   <HomeBreadcrumb />
-  {#each page.url.pathname.split('/').slice(1) as path}
+  {#each page.url.pathname.split('/').slice(1) as path (path)}
     <PageBreadcrumb>{path}</PageBreadcrumb>
   {/each}
 {/if}
diff --git a/frontend/src/routes/email/tester/+page@.svelte b/frontend/src/routes/email/tester/+page@.svelte
index 0319b1cc4f..a060e6372b 100644
--- a/frontend/src/routes/email/tester/+page@.svelte
+++ b/frontend/src/routes/email/tester/+page@.svelte
@@ -132,7 +132,7 @@
 <label class="label cursor-pointer inline-flex gap-4 m-4">
   <span class="label-text">Email template:</span>
   <select class="select select-info" bind:value={currEmail}>
-    {#each emails as email}
+    {#each emails as email (email)}
       <option value={email}>{email.label ?? email.template.replaceAll(/([a-z])([A-Z])/g, '$1 $2')}</option>
     {/each}
   </select>

From 71ad653e2502f9ad7faa683ffba8980356df5503 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Fri, 25 Jul 2025 08:29:05 +0700
Subject: [PATCH 5/9] Fix eslint warnings in viewer

---
 frontend/viewer/eslint.config.js                       | 10 ----------
 frontend/viewer/src/home/HomeView.svelte               |  2 +-
 frontend/viewer/src/home/Server.svelte                 |  2 +-
 frontend/viewer/src/home/ServersList.svelte            |  2 +-
 frontend/viewer/src/lib/DictionaryEntry.svelte         |  5 ++++-
 frontend/viewer/src/lib/activity/ActivityView.svelte   |  2 +-
 .../components/reorderer/reorderer-item-list.svelte    |  2 +-
 .../src/lib/entry-editor/EntryOrSensePicker.svelte     |  2 +-
 .../viewer/src/lib/entry-editor/ItemListItem.svelte    |  6 ++++++
 .../viewer/src/lib/entry-editor/NewEntryDialog.svelte  |  2 +-
 frontend/viewer/src/lib/i18n/LocalizationPicker.svelte |  2 +-
 frontend/viewer/src/lib/sandbox/EditorSandbox.svelte   |  1 +
 frontend/viewer/src/lib/sandbox/Sandbox.svelte         | 10 +++++-----
 frontend/viewer/src/lib/utils/url.svelte.ts            |  6 +++---
 frontend/viewer/src/project/ProjectDropdown.svelte     |  2 +-
 frontend/viewer/src/project/browse/EntryView.svelte    |  2 +-
 frontend/viewer/src/project/browse/SortMenu.svelte     |  5 ++++-
 frontend/viewer/src/project/browse/ViewPicker.svelte   |  2 +-
 .../stories/editor/misc/entry-picker.stories.svelte    |  2 +-
 .../src/stories/editor/misc/reorderer.stories.svelte   |  2 +-
 .../src/stories/primitives/button.stories.svelte       |  8 ++++----
 21 files changed, 40 insertions(+), 37 deletions(-)

diff --git a/frontend/viewer/eslint.config.js b/frontend/viewer/eslint.config.js
index a2918fe5d8..9db20ea3fe 100644
--- a/frontend/viewer/eslint.config.js
+++ b/frontend/viewer/eslint.config.js
@@ -154,14 +154,4 @@ export default [
     },
   },
   ...storybook.configs["flat/recommended"],
-  {
-    // TEMPORARY IGNORES, to be gotten rid of as soon as possible - 2025-07-24 RM
-    files: ['**/*.svelte', '**/*.svelte.ts'],
-    rules: {
-      'svelte/require-each-key': 'off',
-      'svelte/no-useless-mustaches': 'off',
-      'svelte/prefer-svelte-reactivity': 'off',
-      'svelte/no-unused-props': 'off',
-    },
-  },
 ];
diff --git a/frontend/viewer/src/home/HomeView.svelte b/frontend/viewer/src/home/HomeView.svelte
index 878dae5dd9..c891762fba 100644
--- a/frontend/viewer/src/home/HomeView.svelte
+++ b/frontend/viewer/src/home/HomeView.svelte
@@ -188,7 +188,7 @@
               </ButtonListItem>
             {/each}
             <DevContent>
-              <ButtonListItem href={`/testing/project-view`}>
+              <ButtonListItem href="/testing/project-view">
                 <ListItem title={$t`Test Project`} icon={mdiTestTube}
                           classes={{root: 'dark:bg-muted/50 bg-muted/80 hover:bg-muted/30 hover:dark:bg-muted'}}>
                   <div slot="actions" class="pointer-events-none shrink-0">
diff --git a/frontend/viewer/src/home/Server.svelte b/frontend/viewer/src/home/Server.svelte
index 22c0305cad..ec657a89ef 100644
--- a/frontend/viewer/src/home/Server.svelte
+++ b/frontend/viewer/src/home/Server.svelte
@@ -100,7 +100,7 @@
       </p>
     {:else}
       <div class="shadow rounded">
-        {#each projects as project}
+        {#each projects as project (project.id)}
           {@const localProject = matchesProject(localProjects, project)}
           {#if localProject?.crdt}
             <ButtonListItem href={`/project/${project.code}`}>
diff --git a/frontend/viewer/src/home/ServersList.svelte b/frontend/viewer/src/home/ServersList.svelte
index bdbbc4beec..f7090d6a70 100644
--- a/frontend/viewer/src/home/ServersList.svelte
+++ b/frontend/viewer/src/home/ServersList.svelte
@@ -55,7 +55,7 @@
 {#await serversPromise}
   <Server status={undefined} projects={[]} localProjects={[]} loading={true}/>
 {:then serversStatus}
-  {#each serversStatus as status}
+  {#each serversStatus as status (status.server.id)}
     {@const server = status.server}
     {@const serverProjects = remoteProjects[server.id]?.filter(p => p.crdt) ?? []}
     <Server {status}
diff --git a/frontend/viewer/src/lib/DictionaryEntry.svelte b/frontend/viewer/src/lib/DictionaryEntry.svelte
index 184c56f362..40ee798684 100644
--- a/frontend/viewer/src/lib/DictionaryEntry.svelte
+++ b/frontend/viewer/src/lib/DictionaryEntry.svelte
@@ -93,6 +93,7 @@
   {:else}
     <span class="font-bold">{index + 1}</span>
   {/if}
+  <!-- eslint-disable-next-line svelte/no-useless-mustaches This mustache is not useless, it preserves whitespace -->
   {' · '}
 {/snippet}
 
@@ -102,6 +103,7 @@
   </div>
   <strong class="mr-1">
     {#each headwords as headword, i (headword.wsId)}
+      <!-- eslint-disable-next-line svelte/no-useless-mustaches This mustache is not useless, it preserves whitespace -->
       {#if i > 0}{' / '}{/if}
       <span class={headword.color}>{headword.value}</span>
     {/each}
@@ -123,11 +125,12 @@
         {#if glossAndDef.definition}
           <span class={glossAndDef.color}>{glossAndDef.definition}</span>
         {/if}
+        <!-- eslint-disable-next-line svelte/no-useless-mustaches This mustache is not useless, it is deliberately an empty string with no whitespace -->
         {''}
       {/each}
     </span>
     {#each sense.exampleSentences as example (example.id)}
-      {#each example.sentences as sentence, j}
+      {#each example.sentences as sentence, j (sentence)}
         {@const first = j === 0}
         {@const last = j === example.sentences.length - 1}
         {#if j > 0};{/if}
diff --git a/frontend/viewer/src/lib/activity/ActivityView.svelte b/frontend/viewer/src/lib/activity/ActivityView.svelte
index 4b22e57e3b..83dbeec6e7 100644
--- a/frontend/viewer/src/lib/activity/ActivityView.svelte
+++ b/frontend/viewer/src/lib/activity/ActivityView.svelte
@@ -109,7 +109,7 @@
         <div
           class="change-list col-start-2 row-start-2 flex flex-col gap-4 overflow-auto p-1 border rounded h-max max-h-full">
           <InfiniteScroll perPage={100} items={selectedRow.changes} let:visibleItems>
-            {#each visibleItems as change}
+            {#each visibleItems as change (change)}
               <div class="change whitespace-pre-wrap font-mono text-sm">
                 {formatJsonForUi(change)}
               </div>
diff --git a/frontend/viewer/src/lib/components/reorderer/reorderer-item-list.svelte b/frontend/viewer/src/lib/components/reorderer/reorderer-item-list.svelte
index 27459283e5..8cf5240e7b 100644
--- a/frontend/viewer/src/lib/components/reorderer/reorderer-item-list.svelte
+++ b/frontend/viewer/src/lib/components/reorderer/reorderer-item-list.svelte
@@ -41,7 +41,7 @@
 </script>
 
 <DropdownMenu.Group {...mergedProps}>
-  {#each displayItems as item, i}
+  {#each displayItems as item, i (item)}
     {@const reorderName = getDisplayName(item) || '–'}
     <DropdownMenu.Item class="grid grid-cols-subgrid col-span-full justify-items-start items-center"
       onmouseover={() => displayIndex = i}
diff --git a/frontend/viewer/src/lib/entry-editor/EntryOrSensePicker.svelte b/frontend/viewer/src/lib/entry-editor/EntryOrSensePicker.svelte
index 95041cf0ae..8419a01f63 100644
--- a/frontend/viewer/src/lib/entry-editor/EntryOrSensePicker.svelte
+++ b/frontend/viewer/src/lib/entry-editor/EntryOrSensePicker.svelte
@@ -215,7 +215,7 @@
               </Badge>
             {/if}
           </ListItem>
-          {#each selectedEntry.senses as sense}
+          {#each selectedEntry.senses as sense (sense.id)}
             {@const disabledSense = disableSense?.(sense, selectedEntry)}
             <SenseRow
               {sense}
diff --git a/frontend/viewer/src/lib/entry-editor/ItemListItem.svelte b/frontend/viewer/src/lib/entry-editor/ItemListItem.svelte
index 3e3d0378bb..bc90f377cd 100644
--- a/frontend/viewer/src/lib/entry-editor/ItemListItem.svelte
+++ b/frontend/viewer/src/lib/entry-editor/ItemListItem.svelte
@@ -23,12 +23,18 @@
 
   let {
     item,
+    // TODO: Either use `index` or remove it as a prop
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    index,
     items = $bindable(),
     readonly,
     orderable = false,
     getDisplayName,
     onchange,
     menuItems,
+    // TODO: Either use `actions` or remove it as a prop
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    actions,
   } : ItemListItemProps<T> = $props();
 
   const displayName = $derived(getDisplayName(item) || '–');
diff --git a/frontend/viewer/src/lib/entry-editor/NewEntryDialog.svelte b/frontend/viewer/src/lib/entry-editor/NewEntryDialog.svelte
index d309d5e758..bca8591e68 100644
--- a/frontend/viewer/src/lib/entry-editor/NewEntryDialog.svelte
+++ b/frontend/viewer/src/lib/entry-editor/NewEntryDialog.svelte
@@ -101,7 +101,7 @@
     </OverrideFields>
     {#if errors.length}
       <div class="text-end space-y-2">
-        {#each errors as error}
+        {#each errors as error (error)}
           <p class="text-destructive">{error}</p>
         {/each}
       </div>
diff --git a/frontend/viewer/src/lib/i18n/LocalizationPicker.svelte b/frontend/viewer/src/lib/i18n/LocalizationPicker.svelte
index 7afd93be16..8fa17883b7 100644
--- a/frontend/viewer/src/lib/i18n/LocalizationPicker.svelte
+++ b/frontend/viewer/src/lib/i18n/LocalizationPicker.svelte
@@ -28,7 +28,7 @@
   </DropdownMenu.Trigger>
   <DropdownMenu.Content>
     <DropdownMenu.RadioGroup bind:value={() => $locale, l => setLanguage(l)}>
-      {#each Object.entries(languages) as [lang, label]}
+      {#each Object.entries(languages) as [lang, label] (lang)}
         <DropdownMenu.RadioItem class="cursor-pointer" value={lang}>{label}</DropdownMenu.RadioItem>
       {/each}
     </DropdownMenu.RadioGroup>
diff --git a/frontend/viewer/src/lib/sandbox/EditorSandbox.svelte b/frontend/viewer/src/lib/sandbox/EditorSandbox.svelte
index 48e6184cb1..01a7fb60b3 100644
--- a/frontend/viewer/src/lib/sandbox/EditorSandbox.svelte
+++ b/frontend/viewer/src/lib/sandbox/EditorSandbox.svelte
@@ -76,6 +76,7 @@
   }
 </script>
 
+<!-- eslint-disable svelte/no-useless-mustaches - This is a sandbox, we don't need translations -->
 <ResizablePaneGroup direction="horizontal">
   <ResizablePane class="!overflow-visible" defaultSize={75}>
     <Editor.Root class="my-4 border px-4 py-8 relative z-0">
diff --git a/frontend/viewer/src/lib/sandbox/Sandbox.svelte b/frontend/viewer/src/lib/sandbox/Sandbox.svelte
index dfe93093aa..86912fb249 100644
--- a/frontend/viewer/src/lib/sandbox/Sandbox.svelte
+++ b/frontend/viewer/src/lib/sandbox/Sandbox.svelte
@@ -191,7 +191,7 @@
                         mode={pickerMode}
                         pick={(e) => selectedEntryHistory.push(e)}/>
     <div>
-      {#each selectedEntryHistory as selected}
+      {#each selectedEntryHistory as selected (selected.entry.id)}
         <p>
           Entry: {writingSystemService.headword(selected.entry)}
           {#if selected.sense}
@@ -322,16 +322,16 @@
       </div>
       <div><Button onclick={testLoading}>Test loading</Button></div>
       <div class="flex gap-2 flex-wrap">
-        {#each variants as variant}
+        {#each variants as variant (variant)}
           <Button loading={buttonsLoading} {variant}>{variant} button</Button>
         {/each}
-        {#each variants as variant}
+        {#each variants as variant (variant)}
           <Button loading={buttonsLoading} {variant} icon="i-mdi-auto-fix"></Button>
         {/each}
-        {#each sizes as size}
+        {#each sizes as size (size)}
           <Button loading={buttonsLoading} {size}>Size: {size}</Button>
         {/each}
-        {#each sizes as size}
+        {#each sizes as size (size)}
           <Button loading={buttonsLoading} {size} icon="i-mdi-auto-fix"/>
         {/each}
       </div>
diff --git a/frontend/viewer/src/lib/utils/url.svelte.ts b/frontend/viewer/src/lib/utils/url.svelte.ts
index 3f62181831..b3d0668a2c 100644
--- a/frontend/viewer/src/lib/utils/url.svelte.ts
+++ b/frontend/viewer/src/lib/utils/url.svelte.ts
@@ -1,4 +1,4 @@
-import {createSubscriber} from 'svelte/reactivity';
+import {createSubscriber, SvelteURL} from 'svelte/reactivity';
 import {queueHistoryChange} from './history';
 import {useLocation} from 'svelte-routing';
 
@@ -39,7 +39,7 @@ export class QueryParamState {
     this.#waitingForHistoryChange = true;
     await queueHistoryChange(() => {
       try {
-        const currentUrl = new URL(document.location.href);
+        const currentUrl = new SvelteURL(document.location.href);
         if (isDefault) {
           currentUrl.searchParams.delete(this.config.key);
         } else {
@@ -95,7 +95,7 @@ export class QueryParamState {
   }
 
   private readUrlValue(): string {
-    return new URL(document.location.href).searchParams.get(this.config.key) ?? this.defaultValue;
+    return new SvelteURL(document.location.href).searchParams.get(this.config.key) ?? this.defaultValue;
   }
 }
 
diff --git a/frontend/viewer/src/project/ProjectDropdown.svelte b/frontend/viewer/src/project/ProjectDropdown.svelte
index 913188eabd..9ced5b95ed 100644
--- a/frontend/viewer/src/project/ProjectDropdown.svelte
+++ b/frontend/viewer/src/project/ProjectDropdown.svelte
@@ -107,7 +107,7 @@
           </Command.Loading>
         {:else}
           <Command.Empty>{$t`No Dictionaries found`}</Command.Empty>
-          {#each projectsResource.current ?? [] as project}
+          {#each projectsResource.current ?? [] as project (project.id)}
             <Command.Item
               value={project.name + project.crdt}
               onSelect={() => handleSelect(project)}
diff --git a/frontend/viewer/src/project/browse/EntryView.svelte b/frontend/viewer/src/project/browse/EntryView.svelte
index 048de3df60..8b66ea73b7 100644
--- a/frontend/viewer/src/project/browse/EntryView.svelte
+++ b/frontend/viewer/src/project/browse/EntryView.svelte
@@ -68,7 +68,7 @@
     <DictionaryEntry {entry} showLinks class={cn('rounded bg-muted/80 dark:bg-muted/50 p-4')}>
       {#snippet actions()}
         <Toggle bind:pressed={() => sticky, (value) => dictionaryPreview = value ? 'sticky' : 'show'}
-          aria-label={`Toggle pinned`} class="aspect-square" size="xs">
+          aria-label={$t`Toggle pinned`} class="aspect-square" size="xs">
           <Icon icon="i-mdi-pin-outline" class="size-5" />
         </Toggle>
       {/snippet}
diff --git a/frontend/viewer/src/project/browse/SortMenu.svelte b/frontend/viewer/src/project/browse/SortMenu.svelte
index b943231781..d7851975e9 100644
--- a/frontend/viewer/src/project/browse/SortMenu.svelte
+++ b/frontend/viewer/src/project/browse/SortMenu.svelte
@@ -42,6 +42,9 @@
   let {
     value = $bindable(),
     autoSelector,
+    // TODO: Either use `autoDirection` or remove it as a prop
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    autoDirection,
   }: Props = $props();
 
   let selectedSortField = $state<SortField>();
@@ -75,7 +78,7 @@
           ({$t(sortLabels[autoSort])})
         </span>
     </ResponsiveMenu.Item>
-    {#each sortOptions as option}
+    {#each sortOptions as option (option)}
       {@const icon = sortIcons[option.field]?.[option.dir]}
       <ResponsiveMenu.Item
         onSelect={() => {
diff --git a/frontend/viewer/src/project/browse/ViewPicker.svelte b/frontend/viewer/src/project/browse/ViewPicker.svelte
index 139c62f3a2..ba2770bb89 100644
--- a/frontend/viewer/src/project/browse/ViewPicker.svelte
+++ b/frontend/viewer/src/project/browse/ViewPicker.svelte
@@ -30,7 +30,7 @@
   <div class="space-y-2 md:space-y-4">
     <RadioGroup.Root bind:value={getCurrentView, setCurrentView}>
       <h3 class="font-normal max-md:mb-1">{$t`Field Labels`}</h3>
-      {#each views as view}
+      {#each views as view (view.id)}
         <RadioGroup.Item value={view.id} label={view.label} />
       {/each}
     </RadioGroup.Root>
diff --git a/frontend/viewer/src/stories/editor/misc/entry-picker.stories.svelte b/frontend/viewer/src/stories/editor/misc/entry-picker.stories.svelte
index e1701b73a1..45afb0c1e0 100644
--- a/frontend/viewer/src/stories/editor/misc/entry-picker.stories.svelte
+++ b/frontend/viewer/src/stories/editor/misc/entry-picker.stories.svelte
@@ -43,7 +43,7 @@
   </div>
 
   <div>
-    {#each selectedEntryHistory as selected}
+    {#each selectedEntryHistory as selected (selected.entry.id)}
       <p>
         Entry: {writingSystemService?.headword(selected.entry)}
         {#if selected.sense}
diff --git a/frontend/viewer/src/stories/editor/misc/reorderer.stories.svelte b/frontend/viewer/src/stories/editor/misc/reorderer.stories.svelte
index 6d3e4e9e4f..42298ec1da 100644
--- a/frontend/viewer/src/stories/editor/misc/reorderer.stories.svelte
+++ b/frontend/viewer/src/stories/editor/misc/reorderer.stories.svelte
@@ -36,7 +36,7 @@
 </div>
 
 <code>
-  {#each items as item}
+  {#each items as item (item)}
     <span class={cn('p-2 inline-block', item === currentItem && 'text-primary font-bold')}>
       {displayFunc(item)}
     </span>
diff --git a/frontend/viewer/src/stories/primitives/button.stories.svelte b/frontend/viewer/src/stories/primitives/button.stories.svelte
index aed032f26e..2c6bed672b 100644
--- a/frontend/viewer/src/stories/primitives/button.stories.svelte
+++ b/frontend/viewer/src/stories/primitives/button.stories.svelte
@@ -30,7 +30,7 @@
       <div>
         Variants:
         <div class="flex gap-2 flex-wrap">
-          {#each variants as variant}
+          {#each variants as variant (variant)}
             <Button {variant} {...args}>{variant} button</Button>
           {/each}
         </div>
@@ -38,7 +38,7 @@
       <div>
         Variants with icon:
         <div class="flex gap-2 flex-wrap">
-          {#each variants as variant}
+          {#each variants as variant (variant)}
             <Button {variant} icon="i-mdi-auto-fix" {...args}></Button>
           {/each}
         </div>
@@ -46,7 +46,7 @@
       <div>
         Sizes:
         <div class="flex gap-2 flex-wrap">
-          {#each sizes as size}
+          {#each sizes as size (size)}
             <Button {size} {...args}>{size}</Button>
           {/each}
         </div>
@@ -54,7 +54,7 @@
       <div>
         Sizes with icon:
         <div class="flex gap-2 flex-wrap">
-          {#each sizes as size}
+          {#each sizes as size (size)}
             <Button {size} icon="i-mdi-auto-fix" {...args} />
           {/each}
         </div>

From eebaaacd24bc942f08a8fd61203e86d9ed6d3a7f Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Fri, 25 Jul 2025 10:00:12 +0700
Subject: [PATCH 6/9] Add one missed file

---
 frontend/viewer/src/lib/entry-editor/ItemList.svelte | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/viewer/src/lib/entry-editor/ItemList.svelte b/frontend/viewer/src/lib/entry-editor/ItemList.svelte
index 3081133714..0deb60fdfa 100644
--- a/frontend/viewer/src/lib/entry-editor/ItemList.svelte
+++ b/frontend/viewer/src/lib/entry-editor/ItemList.svelte
@@ -20,7 +20,7 @@
 </script>
 
 <div class="flex gap-2 flex-wrap items-center">
-  {#each items as item, index}
+  {#each items as item, index (item)}
     <ItemListItem
       {item}
       {index}

From ada9f658f30d802815e47f7711485c4b8db222b8 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Wed, 30 Jul 2025 12:10:32 +0700
Subject: [PATCH 7/9] Use index as #each key when uniqueness not guaranteed

In a few places, like when iterating over strings from a URL path, we
can't 100% guarantee that they will be unique, so it's better to use the
index as the key. This can result in unnecessary re-renderings, but this
is better than the result that would happen if a Svelte #each block
ended up with the same key pointing at multiple items in the #each. And
there won't be many re-renderings in most of these cases, as they are
not things that change frequently (if at all) in the UI.
---
 frontend/src/lib/components/TrainTracks.svelte         | 4 ++--
 frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte | 2 +-
 frontend/src/routes/+error.svelte                      | 2 +-
 frontend/src/routes/email/tester/+page@.svelte         | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/frontend/src/lib/components/TrainTracks.svelte b/frontend/src/lib/components/TrainTracks.svelte
index 276f8a8381..dc4da188c9 100644
--- a/frontend/src/lib/components/TrainTracks.svelte
+++ b/frontend/src/lib/components/TrainTracks.svelte
@@ -113,10 +113,10 @@
 {#if circles?.length > 0}
   <svg width={maxWidth} height="0" style="height: 100%">
     {#if rowHeights?.length > 0}
-      {#each curves as curve (curve)}
+      {#each curves as curve, i (i)}
         <path fill="none" stroke={curve.color} stroke-width="1.5" d={curve.d} />
       {/each}
-      {#each svgDots as c (c)}
+      {#each svgDots as c, i (i)}
         <circle cx={c.x} cy={c.y} r={circleSize} fill={c.color} stroke="none" style="" />
       {/each}
     {/if}
diff --git a/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte b/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte
index 3c59488c16..78e7908fee 100644
--- a/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte
+++ b/frontend/src/lib/layout/Breadcrumbs/Breadcrumbs.svelte
@@ -9,7 +9,7 @@
 
 <div class="text-sm breadcrumbs p-0 max-xs:invisible">
   <ul>
-    {#each $crumbs as crumb (crumb)}
+    {#each $crumbs as crumb, i (i)}
       <RenderElement tag="li" el={crumb}/>
     {/each}
   </ul>
diff --git a/frontend/src/routes/+error.svelte b/frontend/src/routes/+error.svelte
index 172d6ee369..2e8a5aad5b 100644
--- a/frontend/src/routes/+error.svelte
+++ b/frontend/src/routes/+error.svelte
@@ -9,7 +9,7 @@
 
 {#if page.data.user}
   <HomeBreadcrumb />
-  {#each page.url.pathname.split('/').slice(1) as path (path)}
+  {#each page.url.pathname.split('/').slice(1) as path, i (i)}
     <PageBreadcrumb>{path}</PageBreadcrumb>
   {/each}
 {/if}
diff --git a/frontend/src/routes/email/tester/+page@.svelte b/frontend/src/routes/email/tester/+page@.svelte
index a060e6372b..dfde105fe5 100644
--- a/frontend/src/routes/email/tester/+page@.svelte
+++ b/frontend/src/routes/email/tester/+page@.svelte
@@ -132,7 +132,7 @@
 <label class="label cursor-pointer inline-flex gap-4 m-4">
   <span class="label-text">Email template:</span>
   <select class="select select-info" bind:value={currEmail}>
-    {#each emails as email (email)}
+    {#each emails as email, i (i)}
       <option value={email}>{email.label ?? email.template.replaceAll(/([a-z])([A-Z])/g, '$1 $2')}</option>
     {/each}
   </select>

From c3e6d9c9efc9274c2379cdb25bb7edd252dee4c9 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Thu, 31 Jul 2025 13:54:50 +0700
Subject: [PATCH 8/9] No need for a commented-out line

---
 frontend/svelte.config.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/frontend/svelte.config.js b/frontend/svelte.config.js
index 24a8a3e4e3..cb0ec7e3cd 100644
--- a/frontend/svelte.config.js
+++ b/frontend/svelte.config.js
@@ -5,7 +5,6 @@ import { vitePreprocess } from '@sveltejs/vite-plugin-svelte';
 const config = {
   compilerOptions: {
     warningFilter: (warning) => warning.code != 'element_invalid_self_closing_tag',
-    // enableSourcemap: true // Sourcemaps are always on in Svelte 5, no need to enable them explicitly
   },
   onwarn: (warning, handler) => {
     // eslint-plugin-svelte needs its own warning filter, duplicating the one from compilerOptions

From e653f8b168637259038729e9081999cb76223ff3 Mon Sep 17 00:00:00 2001
From: Robin Munn <rmunn@pobox.com>
Date: Thu, 31 Jul 2025 13:57:50 +0700
Subject: [PATCH 9/9] Fix two new lint errors introduced after PR started

---
 frontend/viewer/src/project/browse/filter/OpFilter.svelte | 2 +-
 frontend/viewer/src/project/browse/filter/WsSelect.svelte | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/viewer/src/project/browse/filter/OpFilter.svelte b/frontend/viewer/src/project/browse/filter/OpFilter.svelte
index 307e03a8f8..f2cdc1866e 100644
--- a/frontend/viewer/src/project/browse/filter/OpFilter.svelte
+++ b/frontend/viewer/src/project/browse/filter/OpFilter.svelte
@@ -24,7 +24,7 @@
   <Select.Content>
     <Select.Group>
       <Select.GroupHeading>Filter By</Select.GroupHeading>
-      {#each ops as op}
+      {#each ops as op (op.value)}
         <Select.Item value={op.value}>
           <Icon icon={op.icon} class="mr-2"/>
           {op.label}
diff --git a/frontend/viewer/src/project/browse/filter/WsSelect.svelte b/frontend/viewer/src/project/browse/filter/WsSelect.svelte
index b45931b143..82bc5a2f99 100644
--- a/frontend/viewer/src/project/browse/filter/WsSelect.svelte
+++ b/frontend/viewer/src/project/browse/filter/WsSelect.svelte
@@ -27,7 +27,7 @@
   <Select.Content>
     <Select.Group>
       <Select.GroupHeading>{$t`Writing Systems`}</Select.GroupHeading>
-      {#each writingSystems as ws}
+      {#each writingSystems as ws (ws.id)}
         <Select.Item value={ws.wsId}>
           {ws.abbreviation} ({ws.wsId})
         </Select.Item>