Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for worker_threads module #401

Open
rafixer opened this issue Sep 17, 2020 · 3 comments · May be fixed by #403
Open

Support for worker_threads module #401

rafixer opened this issue Sep 17, 2020 · 3 comments · May be fixed by #403
Labels
enhancement

Comments

@rafixer
Copy link

rafixer commented Sep 17, 2020 •
edited
Loading

Hi!

I'm trying to get aggregated metrics for all workers (cluster & worker_threads). My idea is to use exisiting AggregatorRegistry class and pass reference to workers by pushWorkersToQueue method. Here is my first working version: https://github.com/rafixer/prom-client/pull/1/files

Do you want this feature on your libary?
@rafixer rafixer linked a pull request Oct 16, 2020 that will close this issue
Open
@zbjornson
Copy link
Collaborator

zbjornson commented Jan 23, 2021 •
edited
Loading

Sounds reasonable! Please make sure it has tests though. 🙏

Oops, just saw your PR that goes with this 😄 reviewing now.

@zbjornson zbjornson linked a pull request Jan 23, 2021 that will close this issue
feat: support aggregating metrics across workers in a Node.js worker_… #403
Open
@alec-benson
Copy link

Are there any workarounds for instrumenting worker threads while we're waiting for this PR to get merged in?

@himeshkothari
Copy link

can someone please help why this PR is still waiting to be merged ?

@quixote15 quixote15 mentioned this issue Sep 11, 2023
Closed
@jeluard jeluard mentioned this issue May 1, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support aggregating metrics across workers in a Node.js worker_… rafixer/prom-client
4 participants
@zbjornson @rafixer @alec-benson @himeshkothari