Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigstore.dev hamburger menu hidden on Pixel #132

Open
kimsterv opened this issue Mar 11, 2022 · 11 comments
Open

Sigstore.dev hamburger menu hidden on Pixel #132

kimsterv opened this issue Mar 11, 2022 · 11 comments
Assignees
Labels
bug Something isn't working www site Concerning www / marketing site

Comments

@kimsterv
Copy link

A friend reported that the hamburger menu is "hidden" on a pixel and you have to scroll right to see it:
image

@kimsterv kimsterv added the bug Something isn't working label Mar 11, 2022
@lukehinds
Copy link
Member

Get an iPhone @kimsterv !

Just kidding :)

@mdunbavan I don't know much about vue mobile rendering, any tips for where to hunt.

@kimsterv
Copy link
Author

lol. I have an iphone. Works great on iphone :)

@mdunbavan
Copy link
Contributor

Hey @lukehinds @kimsterv I can patch a fix up next week for you :) it is a very simple css overflow fix on an element that is overlapping the bounding container.

@mdunbavan mdunbavan self-assigned this Mar 12, 2022
@gtirloni
Copy link

Same issue on Samsung S21 Ultra with Chrome.

@ltagliaferri ltagliaferri added the www site Concerning www / marketing site label Jul 23, 2022
@remram44
Copy link

remram44 commented Oct 25, 2022

Found this ticket because I'm browsing the GitHub after finding no information about anything on the website. Of course I wouldn't have known to find links by scrolling the page to the right. This needs to be fixed ASAP.

@Neilblaze
Copy link
Contributor

@kimsterv Can I take a shot if it's up for grabs? If yes, would you mind assigning me please? Thanks! :)

@remram44
Copy link

@Neilblaze no one has worked on it in the year it's been an open issue, so you don't have to worry about someone getting to it before you do.

@Neilblaze
Copy link
Contributor

@remram44 😆
Thanks for the followup. I'm on it! 😄

@kimsterv
Copy link
Author

Thank you 🙏

@Neilblaze
Copy link
Contributor

Neilblaze commented Apr 27, 2023

@kimsterv I think we can close this issue now, as it got fixed in #251 😄

Edit: Due to the recent addition of Slack in #257, the issue seems to be alive again. While the issue is only populated on mobile devices (tested on Pixel & iPhone), big-screen & medium-screen devices are counted in the exception list. Adding screenshot below for reference ⬇️

iPhone 13 Pro iPad Air
image image

@ltagliaferri shall I directly create a PR referencing this comment?

@kimsterv kimsterv reopened this Apr 27, 2023
@ltagliaferri
Copy link
Contributor

@Neilblaze feel free to open a PR to fix this, thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working www site Concerning www / marketing site
Projects
None yet
Development

No branches or pull requests

7 participants