Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigstore-rs may be incompatible with root-signing again #429

Open
jku opened this issue Feb 3, 2025 · 3 comments
Open

sigstore-rs may be incompatible with root-signing again #429

jku opened this issue Feb 3, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented Feb 3, 2025

See sigstore/root-signing#1431: We (root-signing) may have done the same mistake as happened previously:

  • a "keyid" in the tuf repository was not updated when the key content was modified
  • this was not noticed by root-signing test suite because
    • no other sigstore clients require keyids to match the content
    • there is no sigstore-rs test in the test suite

I've not confirmed this yet but the report looks correct.

@jku jku added the bug Something isn't working label Feb 3, 2025
@jku
Copy link
Member Author

jku commented Feb 3, 2025

Note that this only affects the parts of sigstore-rs that actually uses awslabs/tough: I believe that's currently the bundle module only.

@exFalso
Copy link

exFalso commented Feb 3, 2025

This indeed broke for us, we have a test that detects breaking changes to root-signing. The error we get in particular is:

Invalid key ID 7247f0dbad85b147e1863bade761243cc785dcb7aa410e7105dd3d2b61a36d2c: calculated 0c87432c3bf09fd99189fdc32fa5eaedf4e4a5fac7bab73fa04a2e0fc64af6f5 at line 76 column 4

@exFalso
Copy link

exFalso commented Feb 3, 2025

Is my understanding correct that this check is not actually necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants