pb-rust: codegen via prost + prost-reflect
#207
Conversation
|
CC @woodruffw |
There was a problem hiding this comment.
Fantastic, this helps clean up uses of protobuf specs in e.g. sigstore/sigstore-rs#311 a lot 🙂
There was a problem hiding this comment.
LGTM, thank you @tnytown!
JIT generation is indeed more idiomatic, although it's slightly out-of-sync with what the rest of this repo does. I have no strong opinion here, though, so I'm happy to merge with this approach assuming @kommendorkapten and @haydentherapper have no objections.
|
(Planning note: once merged, I'll do another RC release to crates.io.) |
|
@tnytown You'll need to rebase here 🙂 |
tnytown
dismissed stale reviews from woodruffw and kommendorkapten
via
62d183f
tnytown
force-pushed
the
ap/pb-rust-prost-reflect
branch
from
6376ca8
to
62d183f
Compare
|
@woodruffw rebased! |
|
Hmm, tests are failing. Taking a look ... |
tnytown
force-pushed
the
ap/pb-rust-prost-reflect
branch
from
5dbaa14
to
68d3ec1
Compare
|
Let's get this in following #213. That way we can do a |
tnytown
force-pushed
the
ap/pb-rust-prost-reflect
branch
from
68d3ec1
to
0326f8e
Compare
take N+1 Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
This reverts commit 8283471. Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
Signed-off-by: Andrew Pan <[email protected]>
tnytown
force-pushed
the
ap/pb-rust-prost-reflect
branch
from
0326f8e
to
cdab22b
Compare
|
This should be ready for merge again, modulo the bump to 0.3 in |
|
protobuf-specs/gen/pb-rust/Cargo.toml Line 3 in 1ef5b8e Edit: From the failing test, I think you just need to regenerate the generated code |
Signed-off-by: Andrew Pan <[email protected]>
|
Oops! I bumped the version and reran |
Summary
Generate Protobuf structs via
prost, handling the Protobuf JSON mapping withprost-reflect.This approach has a few benefits:
base64encoding of thebytestype automatically.i64correctly.Unfortunately,
prostdoesn't handle required fields, so we're still stuck with unwrappingOptionmanually.I also took the liberty of generating the structs JIT with
build.rsrather than using a separatecodegenstep. This slows down CI for Rust significantly since we have to run everything through the Docker container, but this approach is more idiomatic and won't clutter the tree with generated files. We may want to look into caching the build container somehow.Release Note
Documentation