address Diego's review

Author: jxs

protocols/gossipsub/CHANGELOG.md

@@ -5,6 +5,9 @@
 - Remove `Rpc` from the public API.
   See [PR 6091](https://github.com/libp2p/rust-libp2p/pull/6091)
 
+- Report peers with Low scores.
+  See [PR XXXX](https://github.com/libp2p/rust-libp2p/pull/6091)
+
 ## 0.49.2
 
 - Relax `Behaviour::with_metrics` requirements, do not require DataTransform and TopicSubscriptionFilter to also impl Default

protocols/gossipsub/src/behaviour.rs

@@ -165,7 +165,7 @@ pub enum Event {
         failed_messages: FailedMessages,
     },
     /// A Peer is below the score threshold.
-    LowScorePeers { peer_ids: Vec<PeerId> },
+    BelowThresholdPeers { peer_ids: Vec<PeerId> },
 }
 
 /// A data structure for storing configuration for publishing messages. See [`MessageAuthenticity`]
@@ -2178,7 +2178,7 @@ where
 
             if !peers_to_report.is_empty() {
                 self.events
-                    .push_back(ToSwarm::GenerateEvent(Event::LowScorePeers {
+                    .push_back(ToSwarm::GenerateEvent(Event::BelowThresholdPeers {
                         peer_ids: peers_to_report,
                     }));
             }

protocols/gossipsub/src/behaviour/tests.rs

@@ -6826,11 +6826,16 @@ fn test_low_score_peer_is_reported() {
     let low_score_event = gs
         .events
         .iter()
-        .find(|event| matches!(event, ToSwarm::GenerateEvent(Event::LowScorePeers { .. })))
+        .find(|event| {
+            matches!(
+                event,
+                ToSwarm::GenerateEvent(Event::BelowThresholdPeers { .. })
+            )
+        })
         .unwrap();
 
     match low_score_event {
-        ToSwarm::GenerateEvent(Event::LowScorePeers { peer_ids }) => {
+        ToSwarm::GenerateEvent(Event::BelowThresholdPeers { peer_ids }) => {
             assert_eq!(peer_ids.len(), 2);
             assert!(peer_ids.contains(&peers[0]));
             assert!(peer_ids.contains(&peers[1]));